Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16237: Replace s3 address for assets. #16777

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

ndouglas
Copy link
Contributor

@ndouglas ndouglas commented Jan 9, 2024

Description

See #16237.

This does not fix all of the problem, but I think this fixes the immediate problem. There's a deeper, more significant issue with vets-website and content-build, I think, that will require considerable more effort (and greater risk) to fix.

QA Steps

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 15:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 17:43 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 19:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 20:45 Destroyed
@ndouglas ndouglas marked this pull request as ready for review January 9, 2024 22:14
@ndouglas ndouglas requested a review from a team as a code owner January 9, 2024 22:14
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as expected. Nice work!

@ndouglas ndouglas merged commit 8a12098 into main Jan 10, 2024
26 checks passed
@ndouglas ndouglas deleted the VACMS-16237-Replace-s3-address-for-assets branch January 10, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants