Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump drupal/entity_field_fetch from 1.0.4 to 1.0.6 #16776

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 9, 2024

Relates to #16615
Bumps drupal/entity_field_fetch from 1.0.4 to 1.0.5.

QA steps

As an admin

  1. Visit https://pr16776-sagmbawcwbahfe4bzn5erlyxxy2zljax.ci.cms.va.gov/jsonapi/node/vamc_system_billing_insurance/cbeb033f-c091-4aba-8814-642ae0d389d9?resourceVersion=id%3A657971

    • Validate that all field_cc_* fields have the fetched property
  2. Visit https://pr16776-sagmbawcwbahfe4bzn5erlyxxy2zljax.ci.cms.va.gov/graphql/explorer

  3. Paste in

query MyQuery {
  nodeQuery(limit: 1, filter: {
      conditions: [
        { field: "status", value: ["1"], enabled: true },
        { field: "nid", value: ["42275"]},
        { field: "type", value: ["vamc_system_billing_insurance"] }
      ]
    }) {
    entities {
      ... on NodeVamcSystemBillingInsurance {
        title,
        nid
        uuid
        fieldCcAboveTopOfPage {
          fetched
          fetchedBundle
          targetField
          targetId
          targetType
          value
        }
      }
    }
  }
}

and play the query

  • Validate that fieldCcAboveTopOfPage is populated with the fetched data.
  1. Wait for the FE web to build.
  2. Visit https://web-sagmbawcwbahfe4bzn5erlyxxy2zljax.ci.cms.va.gov/black-hills-health-care/billing-and-insurance/
Screenshot 2024-01-09 at 9 43 27 AM

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps drupal/entity_field_fetch from 1.0.4 to 1.0.6.

---
updated-dependencies:
- dependency-name: drupal/entity_field_fetch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Dependabot: : Pull requests that update a dependency file php Dependabot pull requests that update Php code labels Jan 9, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 04:30 Destroyed
@swirtSJW swirtSJW added Accelerated Publishing Drupal engineering CMS team practice area Centralized Content A content type used across Facilties content labels Jan 9, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@alexfinnarn
Copy link
Contributor

alexfinnarn commented Jan 9, 2024

I performed these QA steps and all passed for me.

QA steps

As an admin

  1. Visit https://pr16776-sagmbawcwbahfe4bzn5erlyxxy2zljax.ci.cms.va.gov/jsonapi/node/vamc_system_billing_insurance/cbeb033f-c091-4aba-8814-642ae0d389d9?resourceVersion=id%3A657971

    • Validate that all field_cc_* fields have the fetched property
    • Make sure the data is distinct and not duplicated
  2. Visit https://pr16776-sagmbawcwbahfe4bzn5erlyxxy2zljax.ci.cms.va.gov/graphql/explorer

  3. Paste in

query MyQuery {
  nodeQuery(limit: 1, filter: {
      conditions: [
        { field: "status", value: ["1"], enabled: true },
        { field: "nid", value: ["42275"]},
        { field: "type", value: ["vamc_system_billing_insurance"] }
      ]
    }) {
    entities {
      ... on NodeVamcSystemBillingInsurance {
        title,
        nid
        uuid
        fieldCcAboveTopOfPage {
          fetched
          fetchedBundle
          targetField
          targetId
          targetType
          value
        }
      }
    }
  }
}

and play the query

  • Validate that fieldCcAboveTopOfPage is populated with the fetched data.
  1. Wait for the FE web to build.
  2. Visit https://web-sagmbawcwbahfe4bzn5erlyxxy2zljax.ci.cms.va.gov/black-hills-health-care/billing-and-insurance/
  • Validate that the four "field_cc_*" fields included in step 1 are rendered on the page.

@alexfinnarn alexfinnarn self-requested a review January 9, 2024 14:47
Copy link
Contributor

@alexfinnarn alexfinnarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the QA steps and they passed.

@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 19:13 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 10, 2024 15:14 Destroyed
@alexfinnarn alexfinnarn merged commit e427a1c into main Jan 10, 2024
19 checks passed
@alexfinnarn alexfinnarn deleted the dependabot/composer/drupal/entity_field_fetch-1.0.6 branch January 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing Centralized Content A content type used across Facilties content dependencies Dependabot: : Pull requests that update a dependency file Drupal engineering CMS team practice area php Dependabot pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants