Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16146 Add VBA banner cypress test. #16737

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Jan 8, 2024

Description

Relates to #16146

Test can be run locally with

ddev composer va:test:cypress -- --spec=tests/cypress/integration/features/content_type/facilities/vba/vba_facility.feature

Note: if this test fails mid-test, it is possible that subsequent runs will fail because the node content is locked by the first fake test user.

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Since this is a testing only issue, the passing of the tests themselves are what should be QA'd

  1. In the demo environment,
    • validate that the test ran and passed.

image

  1. Look at the test in the PR
    • Validate that it covers banner related field visibility (when they should show, and when they should not.
    • Validate that if the node is saved, the values of the banner fields are not saved

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 8, 2024 18:52 Destroyed
@swirtSJW swirtSJW marked this pull request as draft January 8, 2024 19:07
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 18:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 19:50 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-16146-vba-banner-test branch from fc819ab to dc30565 Compare January 9, 2024 21:03
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 21:03 Destroyed
@swirtSJW
Copy link
Contributor Author

swirtSJW commented Jan 9, 2024

Bizarre. Test is failing but the PR says all tests are passing.
image

@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@swirtSJW swirtSJW force-pushed the VACMS-16146-vba-banner-test branch from dc30565 to 5309a6b Compare January 10, 2024 03:54
@swirtSJW swirtSJW self-assigned this Jan 10, 2024
@@ -1 +1 @@
{"tests/cypress/integration/features/content_type/banner.feature":{"time":41656,"weight":5},"tests/cypress/integration/features/content_type/basic_landing_page.feature":{"time":57915,"weight":7},"tests/cypress/integration/features/content_type/campaign_landing_page.feature":{"time":68632,"weight":8},"tests/cypress/integration/features/content_type/checklist.feature":{"time":96389,"weight":12},"tests/cypress/integration/features/content_type/documentation_page.feature":{"time":31999,"weight":4},"tests/cypress/integration/features/content_type/event.feature":{"time":191765,"weight":24},"tests/cypress/integration/features/content_type/full_width_banner_alert.feature":{"time":69385,"weight":8},"tests/cypress/integration/features/content_type/health_care_local_facility.feature":{"time":100,"weight":0},"tests/cypress/integration/features/content_type/health_care_local_health_service.feature":{"time":116987,"weight":15},"tests/cypress/integration/features/content_type/health_care_region_detail_page.feature":{"time":38262,"weight":4},"tests/cypress/integration/features/content_type/landing_page.feature":{"time":70951,"weight":9},"tests/cypress/integration/features/content_type/office.feature":{"time":27849,"weight":3},"tests/cypress/integration/features/content_type/person_profile.feature":{"time":134270,"weight":17},"tests/cypress/integration/features/content_type/press_release.feature":{"time":22282,"weight":2},"tests/cypress/integration/features/content_type/regional_health_care_service_des.feature":{"time":111440,"weight":14},"tests/cypress/integration/features/content_type/step_by_step.feature":{"time":41618,"weight":5},"tests/cypress/integration/features/content_type/vamc_operating_status_and_alerts.feature":{"time":66677,"weight":8},"tests/cypress/integration/features/facilities/facilities_api.feature":{"time":159639,"weight":20},"tests/cypress/integration/features/facilities/vamc_lovell.feature":{"time":4716,"weight":0},"tests/cypress/integration/features/meta/ewa_block.feature":{"time":117670,"weight":15},"tests/cypress/integration/features/meta/step_definitions.feature":{"time":161885,"weight":20},"tests/cypress/integration/features/platform/content_release.feature":{"time":151357,"weight":19},"tests/cypress/integration/features/platform/entity_reference_validation.feature":{"time":65271,"weight":8},"tests/cypress/integration/features/platform/file_upload.feature":{"time":68310,"weight":8},"tests/cypress/integration/features/platform/generate_automatic_url_alias.feature":{"time":64351,"weight":8},"tests/cypress/integration/features/platform/help_center.feature":{"time":37695,"weight":4},"tests/cypress/integration/features/platform/image_crop.feature":{"time":94,"weight":0},"tests/cypress/integration/features/platform/media.feature":{"time":310540,"weight":40},"tests/cypress/integration/features/platform/navigation.feature":{"time":16790,"weight":2},"tests/cypress/integration/features/platform/password_policy.feature":{"time":35899,"weight":4},"tests/cypress/integration/features/platform/permissions.feature":{"time":84030,"weight":10},"tests/cypress/integration/features/platform/text_validation.feature":{"time":104535,"weight":13},"tests/cypress/integration/features/platform/tooltip.feature":{"time":8767,"weight":1},"tests/cypress/integration/features/platform/translation.feature":{"time":128853,"weight":16},"tests/cypress/integration/features/platform/user_login.feature":{"time":43462,"weight":5},"tests/cypress/integration/features/taxonomy_type/va_benefit_taxonomy.feature":{"time":36221,"weight":4}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only edited to change the paths to the facilities related features since they were moved.

@swirtSJW swirtSJW requested a review from omahane January 10, 2024 04:06
@swirtSJW swirtSJW marked this pull request as ready for review January 10, 2024 04:07
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot added Facilities Facilities products (VAMC, Vet Center, etc) and removed refresh-tugboat-cache Used by GHA Tugboat automation labels Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for organizing these better. The tests passed and read well. No questions or concerns.

@swirtSJW
Copy link
Contributor Author

image

@swirtSJW swirtSJW force-pushed the VACMS-16146-vba-banner-test branch from 5309a6b to df1d223 Compare January 11, 2024 18:42
@swirtSJW swirtSJW merged commit a2fb32a into main Jan 11, 2024
14 checks passed
@swirtSJW swirtSJW deleted the VACMS-16146-vba-banner-test branch January 11, 2024 18:42
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 18:42 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants