Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16591: Update Drupal Core to v10.2 #16620

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Jan 2, 2024

Description

Closes #16591

Testing done

Tested locally

Screenshots

QA steps

There are quite a few changes that are part of this, including a few module updates that got swept up in the update process. Please review your products and report any issues that are potential blockers.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Jan 2, 2024
@edmund-dunn edmund-dunn linked an issue Jan 2, 2024 that may be closed by this pull request
6 tasks
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area labels Jan 2, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2024 22:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2024 22:49 Destroyed
@edmund-dunn edmund-dunn requested review from a team January 2, 2024 22:49
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Jan 2, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 3, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 3, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 3, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2024 18:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2024 19:05 Destroyed
@edmund-dunn edmund-dunn changed the title 16591 Updat Drupal Core to v10.2 VACMS-16591: Update Drupal Core to v10.2 Jan 4, 2024
@edmund-dunn edmund-dunn closed this Jan 4, 2024
@edmund-dunn edmund-dunn reopened this Jan 4, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2024 17:25 Destroyed
@edmund-dunn edmund-dunn marked this pull request as ready for review January 4, 2024 19:12
@edmund-dunn edmund-dunn requested review from a team as code owners January 4, 2024 19:12
@edmund-dunn edmund-dunn requested a review from ndouglas January 4, 2024 19:12
@ndouglas ndouglas marked this pull request as draft January 4, 2024 19:13
@edmund-dunn edmund-dunn requested a review from tjheffner January 4, 2024 19:13
@ndouglas
Copy link
Contributor

ndouglas commented Jan 4, 2024

🚨 This can't merge yet -- it'll break on BRD. 🚨

There are a number of things in the devops repo that hardcode references to /usr/local/bin/drush. Those all need to be ripped out first. I'm working on that in #16658 .

EDIT: This should be good to go now.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2024 20:36 Destroyed
@edmund-dunn edmund-dunn marked this pull request as ready for review January 10, 2024 16:09
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 10, 2024 16:26 Destroyed
@edmund-dunn edmund-dunn removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems to be functioning fine (as near as I can tell with limited testing). One small request for history/future sake.

composer.json Show resolved Hide resolved
@swirtSJW
Copy link
Contributor

It does seem like a lot of modules I would not have expected to be updated by a core update were touched.
Just double checking that all of these came in with
ddev composer update drupal/core --with-dependencies?

@jilladams jilladams mentioned this pull request Jan 10, 2024
2 tasks
@swirtSJW
Copy link
Contributor

Drupal modules that got bumped:

  1. animated_gif
  2. core_event_dispatcher (switched from stable to RC)
  3. field_event_dispatcher(switched from stable to RC)
  4. geocoder
  5. geofield
  6. danse
  7. graphql_core
  8. inline_entity_form
  9. simple_oauth
  10. subrequests
  11. views_bulk_operations

Other supports

  1. drush
  2. guzzle
  3. league
  4. symfony

tjheffner
tjheffner previously approved these changes Jan 11, 2024
Copy link
Contributor

@tjheffner tjheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns here for AP purposes, JSON:API outputs as expected

swirtSJW
swirtSJW previously approved these changes Jan 17, 2024
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looked into all the misc module bumps.

#16822 (comment)

For me the only two things of concern are:

  1. The abrupt jump from hook_event_dispatcher from 3.3.4 ->4.0.0-rc1 A version jump and a jump from a stable release to a release candidate is a bit jarring. I looked through the release notes for anything indicating a breaking change or a need for updated config but did not see anything called out specifically.
  2. The security updates in GraphQL had advice on how calls should be performed by downstream callers. But I did not see any indication in the VA CMS issue or on this PR that our primary downstream caller, (content-build) or VA forms, or chatbot teams were notified that they should check for any changes that might be needed.

@edmund-dunn edmund-dunn dismissed stale reviews from swirtSJW and tjheffner via 435a29c January 17, 2024 19:50
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 17, 2024 20:26 Destroyed
Copy link
Contributor

@Becapa Becapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve's review covers a lot of it, but this manually tests well from a Public Websites standpoint - Comment in 16806.

@edmund-dunn edmund-dunn merged commit 0a9b14a into main Jan 17, 2024
18 of 19 checks passed
@edmund-dunn edmund-dunn deleted the 16591-updat-drupal-core-to-v102 branch January 17, 2024 21:07
@jilladams
Copy link
Contributor

@edmund-dunn @BerniXiongA6 @maortiz-27-80 can y'all help clarify for the concerns flagged in code review what is y'alls take on those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Drupal Core to v10.2
8 participants