-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-16591: Update Drupal Core to v10.2 #16620
Conversation
🚨 This can't merge yet -- it'll break on BRD. 🚨 There are a number of things in the EDIT: This should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and seems to be functioning fine (as near as I can tell with limited testing). One small request for history/future sake.
It does seem like a lot of modules I would not have expected to be updated by a core update were touched. |
Drupal modules that got bumped:
Other supports
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns here for AP purposes, JSON:API outputs as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looked into all the misc module bumps.
For me the only two things of concern are:
- The abrupt jump from hook_event_dispatcher from 3.3.4 ->4.0.0-rc1 A version jump and a jump from a stable release to a release candidate is a bit jarring. I looked through the release notes for anything indicating a breaking change or a need for updated config but did not see anything called out specifically.
- The security updates in GraphQL had advice on how calls should be performed by downstream callers. But I did not see any indication in the VA CMS issue or on this PR that our primary downstream caller, (content-build) or VA forms, or chatbot teams were notified that they should check for any changes that might be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steve's review covers a lot of it, but this manually tests well from a Public Websites standpoint - Comment in 16806.
@edmund-dunn @BerniXiongA6 @maortiz-27-80 can y'all help clarify for the concerns flagged in code review what is y'alls take on those? |
Description
Closes #16591
Testing done
Tested locally
Screenshots
QA steps
There are quite a few changes that are part of this, including a few module updates that got swept up in the update process. Please review your products and report any issues that are potential blockers.
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?