-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI UI Hook to Event Subscriber #16552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Workflows (.github/workflows/*.yml)Have you...
|
github-actions
bot
added
Accelerated Publishing
CMS Team
CMS Product team that manages both editor exp and devops
labels
Dec 22, 2023
tjheffner
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to clear caches for the swagger page to load correctly (complained about a missing schema prior), but otherwise this works well. Nice work on the event subscriber!
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 23, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 23, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 23, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 23, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 24, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 24, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 24, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 24, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 31, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 31, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 31, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Dec 31, 2023
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 1, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 1, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 1, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 1, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 2, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 2, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 2, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #16456 by moving a library attachment via a hook to an event subscriber.
Testing done
Manually tested that "/admin/config/services/openapi" only has one JSON schema listed to explore and Swagger UI still works.
Screenshots
QA steps
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing