VACMS-14238 Improve parsing of Facility phone numbers in facility migrations

[swirtSJW]

Description

Relates to #14238

Testing done

Screenshots

Deploy steps for prod

• Enable "bypass data comparison" /admin/config/va-gov-post-api/config
• excecute vba facility migration as update
• execute vamc facility migration as update
• execute VC Outstation migration as update
• execute Mobile Vet center migration as update
• Disable "bypass data comparison" /admin/config/va-gov-post-api/config

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin

Deploy steps for QA

• Enable "bypass data comparison" /admin/config/va-gov-post-api/config
• excecute vba facility migration as update
• execute vamc facility migration as update
• execute VC Outstation migration as update
• execute Mobile Vet center migration as update
• Disable "bypass data comparison" /admin/config/va-gov-post-api/config

1. Vet Center Outstation - > go to phone audit
   • validate 'Direct line' phone numbers with extensions have , ext. in the number
   • validate 'Direct line' phones without extensions look normal (###-###-####)
2. Vet Center Mobile -go to phone audit
   • validate 'Direct line' phone numbers with extensions have , ext. in the number
   • validate phones without extensions look normal
3. VBA go to phone audit
   • validate 'Direct line' phone numbers with extensions have , ext. in the number
   • validate phones without extensions look normal
4. VAMC go to phone audit
   • validate 'Direct line' phone numbers with extensions have , ext. in the number
   • validate 'Mental health' phone numbers with extensions have , ext. in the number
   • validate 'Direct line' phones without extensions look normal
   • validate mental health phones without extensions look normal

• Request content release
• Visit https://web-3l2tvkc7pb0fnsv9iz7hwupxdlici1up.ci.cms.va.gov/beckley-health-care/locations/beckley-va-medical-center/ and make sure phone with ext looks ok.

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[swirtSJW]

Fixed

And existing goods are still good.

[swirtSJW]

This is ready for review. I have run all the migrations and triggered a content release. It is still building should be ready in ~30 minutes.

[swirtSJW]

Given that this will cross too late to get into today's deploy, this should not be merged until after the code freeze has lifted.

[swirtSJW]

Changing this to draft, just to keep it from being merged before end of code freeze.

[swirtSJW]

closing to jiggle the handle on the GHA.

[swirtSJW]

Failing actions slack conversation here

Apparently they will go away on their own or can be ignored.

[swirtSJW]

This is cleared and ready for release AFTER code thaw.

[swirtSJW]

Getting an completely unrelated failure here