Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16411 Add metatag setup for VA Police. #16480

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Dec 18, 2023

Description

Relates to #16411

Screenshots

image

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As any user

  1. Go to a VA Police page and view the page source in the <head>
    • Validate that the page <title> tag contains the pattern "VA Police | {VAMC System Name} | Veterans Affairs"
    • Validate that <meta property="og:title" follows the same pattern ^^
    • Validate that it contains <meta name="description" content="VA police officers help make VA medical centers and other VA health facilities safe for Veterans and their family members." /> which comes from the centralized content
    • Validate that it contains <meta property="og:description" content="VA police officers help make VA medical centers and other VA health facilities safe for Veterans and their family members." /> which comes from the centralized content

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2023 21:44 Destroyed
@swirtSJW swirtSJW marked this pull request as ready for review December 18, 2023 22:00
@swirtSJW swirtSJW requested a review from a team as a code owner December 18, 2023 22:00
@swirtSJW swirtSJW self-assigned this Dec 18, 2023
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all checks out. So meta.

@swirtSJW swirtSJW force-pushed the VACMS-16411-va-police-metatag branch from 0c6f0d1 to 53b9da3 Compare December 19, 2023 01:29
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2023 01:29 Destroyed
@laflannery
Copy link
Contributor

@swirtSJW so all of this looks fine on Drupal but not the front end, that would be the next step, to update it there?

@swirtSJW
Copy link
Contributor Author

@swirtSJW so all of this looks fine on Drupal but not the front end, that would be the next step, to update it there?

@laflannery I am not sure where you looked to see it not on the FE. The VA Police content is not published yet. According to Eli this change in the CMS should just get picked up without any change to the FE because it is picking up whatever values are provided.

@swirtSJW swirtSJW merged commit 31f735d into main Dec 19, 2023
20 checks passed
@swirtSJW swirtSJW deleted the VACMS-16411-va-police-metatag branch December 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants