VACMS-14000: Adds and populates meta tags on VBA Facility #16395
Conversation
omahane
force-pushed
the
VACMS-14000-vba-metatags-config
branch
from
755f4f4 to
3e38160
Compare
omahane
force-pushed
the
VACMS-14000-vba-metatags-config
branch
from
9f660ed to
cdc02c0
Compare
github-actions
bot
added
the
Facilities
omahane
changed the title
| * @return string | ||
| * Status message. | ||
| */ | ||
| function va_gov_set_vba_facility_meta_tags(array &$sandbox) { |
There was a problem hiding this comment.
Minor and not worth moving. Consider for next time around that this could have been done as a "post deploy hook" so that it would run itself without needing a manual step.
There was a problem hiding this comment.
Thanks for the suggestion. I'll look into that at the next opportunity.
| * @param string $revisionId | ||
| * The id of the node revision. | ||
| */ | ||
| function update_field_cc_meta_tags_table(string $nodeId, string $revisionId) { |
There was a problem hiding this comment.
Minor and not worth changing. Consider abstracting this function one level deeper where it is not specific to meta tags but is generic to updating a fetch field. It would need to add a bundle parameter. Then move it to the script library.
There was a problem hiding this comment.
Yes, good thought. I was thinking that this is something that is going to likely need to happen again.
| @@ -36,7 +37,7 @@ dependencies: | |||
| - field.field.node.vba_facility.field_table_of_contents | |||
| - field.field.node.vba_facility.field_timezone | |||
| - node.type.vba_facility | |||
| - workflows.workflow.editorial | |||
| - workflows.workflow.restricted_archive | |||
There was a problem hiding this comment.
Seems odd this is changing this now. This is unrelated to this PR isn't it?
There was a problem hiding this comment.
Yes, it is unrelated. I also thought it odd. But it's correct, and this vestigial workflow should be corrected from main. Are you suggesting we pull this change out and do it in a separate PR that is specific to workflow?
There was a problem hiding this comment.
No. Mainly just wanted to note it as odd... and thought maybe you could shed light on it.
There was a problem hiding this comment.
It is odd, so I ran a little test on Service Region. It turns out the dependency of the manage form display config is only picked up when updating the form itself. Changing the workflow does not result in a config change for the form. So I'll update the Service Region config, too, for consistency.
Description
Relates to #14000
Testing done
Locally
Screenshots
QA steps
In the browser
As an admin
<meta name="description">element<meta name="og:description">elementIn the terminal
drush scr ./scripts/content/VACMS-14000-vba-facility-meta-tags.php/admin/contentdrush crIn the browser
As an admin
<meta name="description">element, and that it says "Placeholder text: Veterans benefits offices provide services to Veterans ... "<meta name="og:description">element and that it says "Placeholder text: Veterans benefits offices provide services to Veterans ... "<meta name="description">element, and that it says "Placeholder text: Veterans benefits offices provide services to Veterans ... "<meta name="og:description">element and that it says "Placeholder text: Veterans benefits offices provide services to Veterans ... "Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated Publishing