Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-16108: Resolves cannot create reussable qa nodes #16291

Merged
merged 3 commits into from
Dec 5, 2023
Merged

VACMS-16108: Resolves cannot create reussable qa nodes #16291

merged 3 commits into from
Dec 5, 2023

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Dec 4, 2023 •
edited
Loading

Description

Relates to #16108

Testing done

Cypress and manual testing.

QA steps

As user a content admin

  1. Visit /node/add/q_a
  2. Fill out the required fields only and save the node
    • Validate the Node saves without a form error.
  3. Visit /node/add/q_a
  4. Select the 'Enable standalone Resources and support page for this Q&A.' checkbox.
    • Validate the link field under the 'Related information' fieldset is required

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 4, 2023 21:01 Destroyed
@timcosgrove
Copy link
Contributor

  1. Visit /node/add/q_a
  2. Fill out the required fields only and save the node
  1. Visit /node/add/q_a
  2. Select the 'Enable standalone Resources and support page for this Q&A.' checkbox.

timcosgrove
timcosgrove approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@timcosgrove timcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@dsasser dsasser merged commit a5ce010 into main Dec 5, 2023
25 checks passed
@dsasser dsasser deleted the VACMS-16108-cannot-create-reussable-qa-nodes branch December 5, 2023 13:34
tjheffner pushed a commit that referenced this pull request Dec 6, 2023
@dsasser @tjheffner
VACMS-16108: Resolves cannot create reussable qa nodes (#16291)
a2736a4 
* VACMS-16108: Removes form errors on link field conditionally based on standalone value.

* VACMS-16108: Adds test for q_a content type.

---------

Co-authored-by: Daniel Sasser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcosgrove timcosgrove timcosgrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsasser @timcosgrove @va-cms-bot