-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-136900: implement text field migration core logic #16227
base: main
Are you sure you want to change the base?
VACMS-136900: implement text field migration core logic #16227
Conversation
…t-text-field-migration-core-logic
…t-text-field-migration-core-logic
…t-text-field-migration-core-logic
…t-text-field-migration-core-logic
GitHub Workflows (.github/workflows/*.yml)Have you...
|
string $entityType, | ||
string $fieldName | ||
) { | ||
$this->reporter = $reporter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
* {@inheritDoc} | ||
*/ | ||
protected function getReporter(): ReporterInterface { | ||
return $this->reporter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
public function run() { | ||
$this->verifyField($this->getSourceType()); | ||
$this->backupFieldTables(); | ||
$this->fieldConfigs = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$fieldConfigs.
$this->verifyField($this->getSourceType()); | ||
$this->backupFieldTables(); | ||
$this->fieldConfigs = []; | ||
$this->formDisplayConfigs = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$formDisplayConfigs.
$this->backupFieldTables(); | ||
$this->fieldConfigs = []; | ||
$this->formDisplayConfigs = []; | ||
$this->viewDisplayConfigs = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$viewDisplayConfigs.
* The bundle. | ||
*/ | ||
public function updateViewDisplayConfig(string $bundle): void { | ||
$this->reporter->reportInfo("Updating view display config for field {$this->fieldName} on bundle {$bundle}..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
* The config. | ||
*/ | ||
public function updateViewDisplayConfigForMode(string $bundle, string $viewMode, array $config): void { | ||
$this->reporter->reportInfo("Updating view display config for field {$this->fieldName} on bundle {$bundle} for view mode {$viewMode}..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Migrator\MigratorBase::$reporter.
* {@inheritDoc} | ||
*/ | ||
public function runMigration(string $entityType, string $fieldName) : void { | ||
$migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
* {@inheritDoc} | ||
*/ | ||
public function rollbackMigration(string $entityType, string $fieldName) : void { | ||
$migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
* {@inheritDoc} | ||
*/ | ||
public function verifyMigration(string $entityType, string $fieldName) : void { | ||
$migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
* {@inheritDoc} | ||
*/ | ||
public function runMigration(string $entityType, string $fieldName) : void { | ||
$migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
* {@inheritDoc} | ||
*/ | ||
public function rollbackMigration(string $entityType, string $fieldName) : void { | ||
$migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
* {@inheritDoc} | ||
*/ | ||
public function verifyMigration(string $entityType, string $fieldName) : void { | ||
$migrator = $this->migrationFactory->getTextToStringLongMigrator($entityType, $fieldName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Drupal\va_gov_live_field_migration\Plugin\Migration\TextToStringLong::$migrationFactory.
Description
Closes #13699.