VACMS-15714 Add VAMC System Police content type #16169

swirtSJW · 2023-11-20T04:57:48Z

Description

Relates to #15714

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin

Go to /admin/structure/types/manage/vamc_system_va_police/document
- Validate that that the content model document exits with links to design, CAIA and others
Go to /node/add/vamc_system_va_police
Complete all required fields (suggest using VISN 20 - VA Alaska to make selection easier)
- For menu link title use 'VA Police'
- save the node
- Validate that the title becomes 'VA Police'
- Validate the alias is /alaska-health-care/va-police

Accessibility QA

As an admin or content editor
For context there are no editor editable fields on this content type. They will all be set by an install script.

Visit https://pr16169-xiwjtl4qmbjrl2kp2oin9dttwrlbc3dt.ci.cms.va.gov/albany-health-care/va-police and evaluate.
Edit the node and evaluate.

validate that all is well or create followup issue(s)

UX QA

As an admin or content editor
For context there are no editor editable fields on this content type. They will all be set by an install script.

Visit https://pr16169-xiwjtl4qmbjrl2kp2oin9dttwrlbc3dt.ci.cms.va.gov/albany-health-care/va-police and evaluate.
Edit the node and evaluate.

validate that all is well or create followup issue(s)

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

swirtSJW · 2023-11-20T15:38:36Z

I added perms.

laflannery · 2023-11-21T17:10:20Z

There is a Preview option at the bottom but I've never seen that in another content type. Is this supposed to be there?
Do the link Text and the Link URL have to be separate, is it possible to combine them like it is on the VAMC System page? Having a naked link like this is bad for accessibility.
Police page

VAMC System page

dsasser

Looks great to me and QA steps were successful:

I had one minor nitpick but it isn't a blocker.

dsasser · 2023-11-21T18:46:16Z

config/sync/node.type.vamc_system_va_police.yml

+description: 'A page about how Veterans see VA Police information for a VAMC system.'
+help: ''
+new_revision: true
+preview_mode: 1


NITPICK:

I know that editors aren't going to be seeing the UI yet (or ever?), but we probably don't need a preview option enabled.

edmund-dunn

All QA steps passed successfully. No issues form me! Nice work!

thejordanwood · 2023-11-21T19:42:42Z

This looks good to me!

I'm curious to know if the link text/link URL can be combined like @laflannery suggested, but if that isn't possible then this is still approved from a UX perspective.

swirtSJW · 2023-11-22T14:50:17Z

There is a Preview option at the bottom but I've never seen that in another content type. Is this supposed to be there?

@dsasser spotted that too. I will remove it. Good catch.

swirtSJW · 2023-11-22T15:11:55Z

Do the link Text and the Link URL have to be separate, is it possible to combine them like it is on the VAMC System page? Having a naked link like this is bad for accessibility.
Police page

@laflannery and @thejordanwood This is the default rendering for the Spotlight content paragraph. If we wanted that to render like a normal CTA it would affect everywhere it is used, and would probably be an issue for CMS Platform Team, not product teams.

I believe the original intent of it rendering as separate fields was for proofing the destination separately from the title. As opposed to preview. It was a conscious choice that may or may not match our current approach.

config/sync/node.type.vamc_system_va_police.yml

swirtSJW · 2023-11-28T19:29:23Z

Something funky going on with Sections.

When I log in as [email protected] who is in the VA Chillicothe health care section, I can edit a VAMC System VA Police Page that is in the Ann Arbor Section, despite not being able to edit any other content in the Ann Arbor section

Good find. Something is up. I am looking into it.

davidmpickett · 2023-11-28T20:35:37Z

I am pretty sure I know the answer to this, but just to check.
Is there an easy way to specify a default "Menu link title" for this content type? We will always want it to be "VA Police" = same as the node title. I couldn't find this as a setting in the Site Building interface and I know menus are weird, but just want to ask and confirm

@davidmpickett there is not in the content type itself. But we will set them when we bulk create them.

EDIT: I take that back. We are doing it on other top task pages.

Small note that when this is set it should be 'VA police' lowercase p per copy edits from CAIA

swirtSJW · 2023-12-01T18:12:04Z

Is there an easy way to specify a default "Menu link title" for this content type? We will always want it to be "VA Police" = same as the node title. I couldn't find this as a setting in the Site Building interface and I know menus are weird, but just want to ask and confirm

@davidmpickett
I found the issue with this. The only way I can prefill the menu link title field is if I show the node title (it is disabled, because auto_entity_label provides the value for the title so it is not editable by anyone) .

There is a choice to be made:
A) show a title field that editors can never touch so that menu link title is populated on a page editors will never create themselves
B) Don't show the title which will keep menu link title from being populated on a page that will be built by a script anyway.

What established pattern do we have you ask???
Unfortunately we have both on our top task pages.

swirtSJW · 2023-12-01T19:10:32Z

The permissions issue has been worked out

He can only modify police content in chilicothe

swirtSJW · 2023-12-01T20:02:54Z

* VACMS-15714 Add VAMC System Police content type * VACMS-15714 Add VAMC Police permissions. * VACMS-15714 Add alias pattern for VA Police. * VACMS-15714 Add auto title, fields and formatting to VAMC police. * VACMS-15714 Add CM document. * VACMS-15714 Make alias based on node title. * Remove preview link. * Add base field override. * VACMS-15714 Show cc labels and change title. * VACMS-15714 Add National term definition. * Add VA Police and supplemental status to workbenc access. * VACMS-15714 Show title field so menu title will populate. * VACMS-15714 Remove breadcrumb settings changes that snuck in.

va-cms-bot temporarily deployed to Tugboat November 20, 2023 04:57 Destroyed

va-cms-bot temporarily deployed to Tugboat November 20, 2023 15:33 Destroyed

swirtSJW force-pushed the VACMS-15714-va-police-page branch from a7ad318 to 2873d9d Compare November 20, 2023 15:53

va-cms-bot temporarily deployed to Tugboat November 20, 2023 15:53 Destroyed

swirtSJW force-pushed the VACMS-15714-va-police-page branch from 2873d9d to 86292d0 Compare November 20, 2023 16:57

va-cms-bot temporarily deployed to Tugboat November 20, 2023 16:58 Destroyed

swirtSJW force-pushed the VACMS-15714-va-police-page branch from 86292d0 to 8389684 Compare November 20, 2023 23:02

va-cms-bot temporarily deployed to Tugboat November 20, 2023 23:02 Destroyed

swirtSJW force-pushed the VACMS-15714-va-police-page branch from 8389684 to d23b5b0 Compare November 21, 2023 04:03

va-cms-bot temporarily deployed to Tugboat November 21, 2023 04:03 Destroyed

va-cms-bot temporarily deployed to Tugboat November 21, 2023 04:22 Destroyed

swirtSJW mentioned this pull request Nov 21, 2023

VAMC System VA Police content type in the CMS #15714

Closed

21 tasks

swirtSJW force-pushed the VACMS-15714-va-police-page branch from 196713a to b49f094 Compare November 21, 2023 15:07

va-cms-bot temporarily deployed to Tugboat November 21, 2023 15:07 Destroyed

swirtSJW marked this pull request as ready for review November 21, 2023 15:18

swirtSJW requested review from a team as code owners November 21, 2023 15:18

va-cms-bot temporarily deployed to Tugboat November 21, 2023 15:46 Destroyed

swirtSJW self-assigned this Nov 21, 2023

swirtSJW requested review from thejordanwood and laflannery November 21, 2023 16:06

dsasser previously approved these changes Nov 21, 2023

View reviewed changes

edmund-dunn previously approved these changes Nov 21, 2023

View reviewed changes

swirtSJW commented Nov 22, 2023

View reviewed changes

config/sync/node.type.vamc_system_va_police.yml Outdated Show resolved Hide resolved

swirtSJW dismissed edmund-dunn’s stale review via 44ac56e November 22, 2023 15:14

va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:27 Destroyed

swirtSJW force-pushed the VACMS-15714-va-police-page branch from d3f7409 to a8d2cf3 Compare November 30, 2023 22:34

va-cms-bot temporarily deployed to Tugboat November 30, 2023 22:34 Destroyed

swirtSJW force-pushed the VACMS-15714-va-police-page branch from a8d2cf3 to 8bed400 Compare December 1, 2023 17:36

va-cms-bot temporarily deployed to Tugboat December 1, 2023 17:36 Destroyed

va-cms-bot temporarily deployed to Tugboat December 1, 2023 19:00 Destroyed

va-cms-bot temporarily deployed to Tugboat December 1, 2023 19:20 Destroyed

swirtSJW and others added 13 commits December 1, 2023 15:03

VACMS-15714 Add VAMC System Police content type

a04ec5f

VACMS-15714 Add VAMC Police permissions.

42dcb1b

VACMS-15714 Add alias pattern for VA Police.

1de786c

VACMS-15714 Add auto title, fields and formatting to VAMC police.

4477129

VACMS-15714 Add CM document.

82f70e8

VACMS-15714 Make alias based on node title.

ac5abff

Remove preview link.

ae4ad0b

Add base field override.

1b483f0

VACMS-15714 Show cc labels and change title.

0ffec78

VACMS-15714 Add National term definition.

6e27318

Add VA Police and supplemental status to workbenc access.

9ab32d4

VACMS-15714 Show title field so menu title will populate.

7de03e7

VACMS-15714 Remove breadcrumb settings changes that snuck in.

53c5054

swirtSJW force-pushed the VACMS-15714-va-police-page branch from 4fecdca to 53c5054 Compare December 1, 2023 20:03

va-cms-bot temporarily deployed to Tugboat December 1, 2023 20:03 Destroyed

swirtSJW merged commit 76febad into main Dec 1, 2023
13 checks passed

swirtSJW deleted the VACMS-15714-va-police-page branch December 1, 2023 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-15714 Add VAMC System Police content type #16169

VACMS-15714 Add VAMC System Police content type #16169

swirtSJW commented Nov 20, 2023 •

edited by thejordanwood

Loading

swirtSJW commented Nov 20, 2023

laflannery commented Nov 21, 2023

dsasser left a comment

dsasser Nov 21, 2023

edmund-dunn left a comment

thejordanwood commented Nov 21, 2023

swirtSJW commented Nov 22, 2023

swirtSJW commented Nov 22, 2023

swirtSJW commented Nov 28, 2023

davidmpickett commented Nov 28, 2023

swirtSJW commented Dec 1, 2023

swirtSJW commented Dec 1, 2023 •

edited

Loading

swirtSJW commented Dec 1, 2023

VACMS-15714 Add VAMC System Police content type #16169

VACMS-15714 Add VAMC System Police content type #16169

Conversation

swirtSJW commented Nov 20, 2023 • edited by thejordanwood Loading

Description

Testing done

Screenshots

QA steps

Accessibility QA

UX QA

Definition of Done

Select Team for PR review

Is this PR blocked by another PR?

Does this PR need review from a Product Owner

CMS user-facing announcement

swirtSJW commented Nov 20, 2023

laflannery commented Nov 21, 2023

dsasser left a comment

Choose a reason for hiding this comment

dsasser Nov 21, 2023

Choose a reason for hiding this comment

edmund-dunn left a comment

Choose a reason for hiding this comment

thejordanwood commented Nov 21, 2023

swirtSJW commented Nov 22, 2023

swirtSJW commented Nov 22, 2023

swirtSJW commented Nov 28, 2023

davidmpickett commented Nov 28, 2023

swirtSJW commented Dec 1, 2023

swirtSJW commented Dec 1, 2023 • edited Loading

swirtSJW commented Dec 1, 2023

swirtSJW commented Nov 20, 2023 •

edited by thejordanwood

Loading

swirtSJW commented Dec 1, 2023 •

edited

Loading