Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-15977: Adds accordion to VBA Facility Prepare for your visit #16161

Merged
merged 3 commits into from
Nov 19, 2023
Merged

VACMS-15977: Adds accordion to VBA Facility Prepare for your visit #16161

merged 3 commits into from
Nov 19, 2023

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Nov 17, 2023 •
edited by swirtSJW
Loading

Description

Relates to #15977

Testing done

Manually

Screenshots

Screenshot 2023-11-17 at 4 00 38 PM

QA steps

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@omahane omahane requested a review from a team as a code owner November 17, 2023 21:05
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 17, 2023 21:05 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 17, 2023 21:46 Destroyed
@omahane omahane changed the title VACMS-15977: Makes prepare for visit config changes VACMS-15977: Adds accordion to VBA Facility Prepare for your visit Nov 17, 2023
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Nov 17, 2023
swirtSJW
swirtSJW approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests out good
image

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 19, 2023 02:42 Destroyed
@swirtSJW
Copy link
Contributor

image

@swirtSJW swirtSJW merged commit c9d4c09 into main Nov 19, 2023
13 of 15 checks passed
@swirtSJW swirtSJW deleted the VACMS-15977-vba-prepare-for-visit branch November 19, 2023 02:42
tjheffner pushed a commit that referenced this pull request Dec 6, 2023
@omahane @swirtSJW @tjheffner
VACMS-15977: Adds accordion to VBA Facility Prepare for your visit (#…
d4f55cb 
…16161)

* VACMS-15977: Makes prepare for visit config changes

* VACMS-15977: Makes node:view better match node:edit

---------

Co-authored-by: Steve Wirt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swirtSJW swirtSJW swirtSJW approved these changes

@davidmpickett davidmpickett Awaiting requested review from davidmpickett

Assignees
No one assigned
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omahane @swirtSJW @va-cms-bot