Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16118: Fix KB link on Vet Center node edit #16158

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

davidmpickett
Copy link
Contributor

@davidmpickett davidmpickett commented Nov 17, 2023

Description

Relates to #16118 (or closes?)

Testing done

Screenshots

QA steps

As user uid with user_role

  1. Do this
    • Edit a Vet Center node
  2. Then
    • Look at the link in the Editing the content section

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@davidmpickett davidmpickett linked an issue Nov 17, 2023 that may be closed by this pull request
6 tasks
@davidmpickett davidmpickett marked this pull request as ready for review November 17, 2023 23:00
@davidmpickett davidmpickett requested a review from a team as a code owner November 17, 2023 23:00
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 17, 2023 23:00 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2023 15:08 Destroyed
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link now goes to the right spot (and opens in a new tab).

@omahane omahane enabled auto-merge (squash) December 5, 2023 15:19
@davidmpickett
Copy link
Contributor Author

Screenshot 2023-12-05 104055
Evidence from Tugboat

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2023 21:02 Destroyed
@omahane omahane merged commit 3091b12 into main Dec 5, 2023
18 checks passed
@omahane omahane deleted the VACMS-16118-Fix-KB-link-in-Vet-Center-node branch December 5, 2023 21:40
tjheffner pushed a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect link in Vet Center content type guidance
3 participants