Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15939: Updates Help Desk email to correct Atlassian domain #16141

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Nov 15, 2023

Description

Relates to #15939

Testing done

Manually

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  • [x]validate that the email address in the message was changed from a .gov to a -gov

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@omahane omahane requested a review from a team as a code owner November 15, 2023 19:57
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good. Not sure what's up with the Tugboat. Looking into that now.

@omahane omahane enabled auto-merge (squash) November 15, 2023 20:44
@swirtSJW swirtSJW closed this Nov 15, 2023
auto-merge was automatically disabled November 15, 2023 20:52

Pull request was closed

@swirtSJW
Copy link
Contributor

re-opening to try to jumpstart tugboat

@swirtSJW swirtSJW reopened this Nov 15, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 15, 2023 20:56 Destroyed
@swirtSJW swirtSJW enabled auto-merge (squash) November 15, 2023 21:13
@swirtSJW swirtSJW merged commit 334e9eb into main Nov 15, 2023
32 checks passed
@swirtSJW swirtSJW deleted the VACMS-15939-update-atlassian-email branch November 15, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants