VACMS-15953 Regenerate phpstan baselines

[JunTaoLuo]

Description

Closes #15953. We are choosing to ignore existing phpstan errors so only new errors will fail the va:test:phpstan check. This ensures local testing matches the CI behaviour.

Testing done

Tested locally using the phpstan composer script, i.e. running composer run-script va:test:phpstan. No more errors are observed.

Screenshots

Before:

After:

QA steps

As user with access to this repository

1. Run the command composer run-script va:test:phpstan locally
   • Validate that PHPStan runs successfully without errors.

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[ndouglas]

root@php:/var/lib/tugboat# composer run-script va:test:phpstan
> # Run PHPStan static analysis tests.
> ! ./scripts/should-run-directly.sh || bin/phpstan analyze --memory-limit=1G --
Note: Using configuration file /var/lib/tugboat/phpstan.neon.
 440/440 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


 [OK] No errors                                                                 

> ./scripts/should-run-directly.sh || ddev composer va:test:phpstan --

[ndouglas]

@JunTaoLuo Just fixed an issue with permissions that I think prevented you from merging a cleanly-mergeable PR into main. That should be up to your judgment as an engineer 🙂

[JunTaoLuo]

Perfect, I was about to ask whether the checks were being overly cautious/restrictive. I'll see if the next one I open feels more reasonable in terms of workflow.

[ndouglas]

@JunTaoLuo Context here: TL;DR: I brought this up a few months back and there was some resistance, so I dropped it. But you're The Man now 🙂