Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15979: fix for reusable documents #15980

Merged

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Nov 2, 2023

Description

Close #15979.

Testing done

Tested locally.

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Navigate to /media/add/document
  • Validate that Reusable field is present and checked by default.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Nov 2, 2023
@edmund-dunn edmund-dunn linked an issue Nov 2, 2023 that may be closed by this pull request
11 tasks
@edmund-dunn edmund-dunn requested a review from ndouglas November 2, 2023 20:51
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area labels Nov 2, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 2, 2023 20:51 Destroyed
Copy link
Contributor

@ndouglas ndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@ndouglas ndouglas merged commit d6b7974 into main Nov 3, 2023
16 checks passed
@ndouglas ndouglas deleted the 15979-reusable-checkbox-missing-from-add-document-form branch November 3, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reusable checkbox missing from add document form
3 participants