Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updates README with information about content-build #15961

Closed
wants to merge 1 commit into from

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Nov 1, 2023

Description

Relates to #15960

Testing done

N/A

Screenshots

N/A

QA steps

  • Is the change correct?

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@omahane omahane requested a review from a team as a code owner November 1, 2023 21:51
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 1, 2023 21:51 Destroyed
@omahane omahane force-pushed the VACMS-15960-update-readme-content-build branch from 7702949 to 9f61c23 Compare November 1, 2023 21:55
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 1, 2023 21:55 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Nov 1, 2023
@@ -124,7 +124,7 @@ The production instance of the CMS is utilized in two main ways:

#### Build and Release Process

In a continuous integration context, the `content-build` project is managed as a dependency of the CMS project; the build script is executed targeting the local instance and runs all of the content queries performed as part of the normal content release process, to ensure no changes have been introduced to the CMS codebase that break compatibility. A full content build happens at the conclusion of the testing pipeline on our [Tugboat](https://tugboat.qa/) preview environments.
In a continuous integration context, the `content-build` project is managed as a dependency of the CMS project; the build script is executed targeting the local instance--the database and code of which is from the day before--and runs all of the content queries performed as part of the normal content release process, to ensure no changes have been introduced to the CMS codebase that break compatibility. A full content build happens at the conclusion of the testing pipeline on our [Tugboat](https://tugboat.qa/) preview environments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct. The database and code are current at the time the build script is run in a CI context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ndouglas ndouglas Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve's comment is referring to the content-build repository's CI process. This section is referring to the va.gov-cms repository's CI process.

In the content-build repository's CI process, the build script is not managed as a dependency of the CMS project and is not executed targeting the local instance of the CMS; there is no local instance.

@omahane omahane closed this Nov 6, 2023
@omahane
Copy link
Contributor Author

omahane commented Nov 6, 2023

Unclear where to add information about the content-build using yesterday's CMS code and db.

@omahane omahane deleted the VACMS-15960-update-readme-content-build branch February 16, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants