Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15747 Feature toggle to launch nat outreach checkbox for all #15930

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Oct 31, 2023

Description

Relates to #15747

Testing done

Manually tested with various user accounts and feature toggle states. Updated cypress test suite for events.

Screenshots

Screenshot 2023-10-31 at 3 21 00 PM

QA steps

As an administrator

  1. Visit the feature toggle page, and ensure that the FEATURE_EVENT_OUTREACH_CHECKBOX_ALL is OFF and the FEATURE_EVENT_OUTREACH_CHECKBOX is ON (this is the state we will launch in production).
  2. Visit the create Event node page
    • Validate you see the 'Publish to the National Outreach Calendar' checkbox.
  3. Fill out the event, ensuring to check the checkbox
  4. Save the event
    • On the subsequent view page, validate the 'Outreach events' event list is listed under 'Additional Listings'

As an Outreach Hub user (eg: [email protected])
5. Visit the create Event node page

  • Validate you DO NOT see the checkbox
  1. Fill out the event
  2. Save the event
  • On the subsequent view page, validate you DO NOT see the 'Outreach events' event listed under 'Additional Listings'

As a content admin
9. Visit the create Event node page

  • Validate you DO NOT see the checkbox
  1. Fill out the event
  2. Save the event
  • On the subsequent view page, validate you DO NOT see the 'Outreach events' event listed under 'Additional Listings'

As an administrator
12. Visit the feature toggle page.
13. Check the box for the FEATURE_EVENT_OUTREACH_CHECKBOX_ALL toggle, and save the form

As an Outreach Hub user (eg: [email protected])
14. Visit the create Event node page

  • Validate you DO see the checkbox
  1. Fill out the event, ensuring the check the checkbox
  2. Save the event
  • On the subsequent view page, validate you DO see the 'Outreach events' event listed under 'Additional Listings'

As a content admin
17. Visit the create Event node page

  • Validate you DO see the checkbox
  1. Fill out the event, ensuring the check the checkbox
  2. Save the event
  • On the subsequent view page, validate you DO see the 'Outreach events' event listed under 'Additional Listings'

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • Public websites

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 31, 2023 20:35 Destroyed
@dsasser dsasser changed the title DNM: VACMS-15747 launch nat checkbox for all DNM: VACMS-15747 Feature toggle to launch nat outreach checkbox for all Oct 31, 2023
@dsasser dsasser requested a review from jilladams November 2, 2023 15:29
@jilladams jilladams requested a review from chri5tia November 2, 2023 15:30
@jilladams
Copy link
Contributor

Approving conceptually, but added @chri5tia for actual code review.

@chri5tia
Copy link
Contributor

chri5tia commented Nov 2, 2023

Great!

@@ -2,8 +2,9 @@
Feature: Content Type: Event

Scenario: Log in and create an event.
Given I am logged in as a user with the "administrator" role
Given I am logged in as a user with the "content_admin" role
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@dsasser dsasser changed the title DNM: VACMS-15747 Feature toggle to launch nat outreach checkbox for all VACMS-15747 Feature toggle to launch nat outreach checkbox for all Nov 3, 2023
@dsasser dsasser merged commit a4119bf into main Nov 3, 2023
31 checks passed
@dsasser dsasser deleted the VACMS-15747-launch-nat-checkbox-for-all branch November 3, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants