-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-15747 Feature toggle to launch nat outreach checkbox for all #15930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll users based on new feature toggle.
dsasser
changed the title
DNM: VACMS-15747 launch nat checkbox for all
DNM: VACMS-15747 Feature toggle to launch nat outreach checkbox for all
Oct 31, 2023
Approving conceptually, but added @chri5tia for actual code review. |
jilladams
approved these changes
Nov 2, 2023
2 tasks
Great! |
chri5tia
reviewed
Nov 2, 2023
@@ -2,8 +2,9 @@ | |||
Feature: Content Type: Event | |||
|
|||
Scenario: Log in and create an event. | |||
Given I am logged in as a user with the "administrator" role | |||
Given I am logged in as a user with the "content_admin" role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
chri5tia
approved these changes
Nov 2, 2023
dsasser
changed the title
DNM: VACMS-15747 Feature toggle to launch nat outreach checkbox for all
VACMS-15747 Feature toggle to launch nat outreach checkbox for all
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #15747
Testing done
Manually tested with various user accounts and feature toggle states. Updated cypress test suite for events.
Screenshots
QA steps
As an administrator
FEATURE_EVENT_OUTREACH_CHECKBOX_ALL
is OFF and theFEATURE_EVENT_OUTREACH_CHECKBOX
is ON (this is the state we will launch in production).As an Outreach Hub user (eg: [email protected])
5. Visit the create Event node page
As a content admin
9. Visit the create Event node page
As an administrator
12. Visit the feature toggle page.
13. Check the box for the
FEATURE_EVENT_OUTREACH_CHECKBOX_ALL
toggle, and save the formAs an Outreach Hub user (eg: [email protected])
14. Visit the create Event node page
As a content admin
17. Visit the create Event node page
Definition of Done
Select Team for PR review
Public websites