Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14214 Add editable mental health number to phone audit. #15928

Merged

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Oct 31, 2023

Description

Relates to #14214 (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin

  1. Go to the phone number audit
    • Validate that there is a new column "Mental health phone (editable)" to the right of "Mental health phone (FAPI)
    • Validate that there are only facilities, system and Billing and insurance in the content types.
    • Validate that a new filter "Editable mental health contact phone" exists and that it has options for empty and not empty as well as contains.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 31, 2023 19:25 Destroyed
@swirtSJW swirtSJW self-assigned this Oct 31, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 31, 2023 20:11 Destroyed
@swirtSJW swirtSJW requested a review from omahane October 31, 2023 20:15
@swirtSJW swirtSJW marked this pull request as ready for review October 31, 2023 20:15
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-03 at 4 18 42 PM

Works as advertised.

@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Nov 3, 2023
@swirtSJW swirtSJW merged commit 71f7aec into integration-mental-health-phone Nov 6, 2023
17 checks passed
@swirtSJW swirtSJW deleted the VACMS-14214-add-mh-number-to-view branch November 6, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants