Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15721: added description field for alert blocks view and browser #15927

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Oct 31, 2023

Description

Closes #15721.

Testing done

Tested localy. Description field now displayed as first column on both the /admin/content/alerts page in the in the entity browser for adding alerts.

Screenshots

CleanShot2023-10-31at12 12 14
CleanShot2023-10-31at12 11 41

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Navigate to /admin/content/alerts
    • Validate that the description column is the first column and is populated
  2. Then add a Benefits Details page, scroll down to the Include Alert section and click Place Alert
    • Validate that the Description column is present and populated

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Oct 31, 2023
@edmund-dunn edmund-dunn linked an issue Oct 31, 2023 that may be closed by this pull request
8 tasks
@edmund-dunn edmund-dunn requested a review from ndouglas October 31, 2023 19:16
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area labels Oct 31, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 31, 2023 19:16 Destroyed
Copy link
Contributor

@ndouglas ndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA steps passed.

@ndouglas ndouglas merged commit 77b2cea into main Nov 1, 2023
18 checks passed
@ndouglas ndouglas deleted the 15721-add-the-block-description-field-to-alert-list branch November 1, 2023 14:00
tjheffner added a commit that referenced this pull request Nov 9, 2023
…#15936)

* gitignore public/private key for oauth

* export config for simple_oauth and next js site

* use simple oauth for preview in next

* echo keys to files in tugboat

* add other env vars where they need to be

* [docs] Update and rename pw-dark-launch.md to dark-launch.md

* Bump datadog/dd-trace from 0.92.2 to 0.93.1 (#15937)

Bumps [datadog/dd-trace](https://github.com/DataDog/dd-trace-php) from 0.92.2 to 0.93.1.
- [Release notes](https://github.com/DataDog/dd-trace-php/releases)
- [Commits](DataDog/dd-trace-php@0.92.2...0.93.1)

---
updated-dependencies:
- dependency-name: datadog/dd-trace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VACMS-14342: Set up `CODEOWNERS` (#15581)

* VACMS-14342: Set up CODEOWNERS

* h/t Dave

* h/t Tanner

* h/t Dave

* Update .github/CODEOWNERS

* Apply suggestions from code review

h/t @swirtSJW

* Bump va-gov/content-build from 0.0.3377 to 0.0.3378 (#15938)

Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3377 to 0.0.3378.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3377...v0.0.3378)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VACMS-15721: added description field for alert blocks view and browser (#15927)

* VACMS-15276: Adds YouTube field (#15450)

* VACMS-15276: Adds YouTube field

* VACMS-15276: Adding field storage for YouTube

* VACMS-15891: Update Q&A Content Report View to use Multiple Workflow Filter (#15896)

* VACMS-15891: Update workflow filter to multiple

* VACMS-15891: Updated the filter machine name too because Jill is smart.

* VACMS-15891: Style-Guide-Related edits to view

* VACMS-15891: Added section filter

* VACMS-15891: Fix caption

* VACMS-15891: Caption and tab

* VACMS-15891: Copying new settings from view family

* VACMS-15891: Fix pager back to 25 for cypress test

* update perms for nextjs role

* update perms for nextjs role

* re-export config for correct dependencies

* override config for tugboat

* include full domains in the url path...

* a couple more env vars in place

* env vars need added before build

* tweak env vars slightly

* quote env vars

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jill Adams <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nate Douglas <[email protected]>
Co-authored-by: Edmund Dunn <[email protected]>
Co-authored-by: Christian Burk <[email protected]>
Co-authored-by: Christia Troyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the block description field to alert list
3 participants