Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15893 Add setup for CM Document export/import. #15894

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Oct 27, 2023

Description

Closes #15893

This PR includes both the initial setup for import and export, AND a sample Content Model Document import about Import / Export (inception much?).

Screenshots

See my comment.

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  • View the build log and validate the update section shows no errors
    image

As an admin

  1. Go to where the newly imported doc should be
    • Validate that the doc has content, a diagram, and a link.
  2. Click on the revisions tab
    • Validate that it has a revision showing the import and that it indicates it was an import.
  3. Go to the recent log messages
    • Validate that there is one entry for the summary of files imported
    • Validate there is one entry for the import of the specific content model document.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@swirtSJW swirtSJW self-assigned this Oct 27, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 27, 2023 21:38 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-15893-set-up-cm-document-import branch from 35ec450 to 017f761 Compare October 28, 2023 01:44
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 28, 2023 01:44 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-15893-set-up-cm-document-import branch from 017f761 to b40edf0 Compare October 28, 2023 02:02
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 28, 2023 02:02 Destroyed
@swirtSJW
Copy link
Contributor Author

swirtSJW commented Oct 28, 2023

Build log output
image

Revision log
image

Recent log messages
image

@swirtSJW swirtSJW marked this pull request as ready for review October 28, 2023 02:20
@swirtSJW swirtSJW requested a review from omahane October 28, 2023 02:24
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin!

I didn't understand the line breaks in this document. It might be worth looking into. NBD, though.
Screenshot 2023-10-30 at 7 42 42 AM

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Oct 30, 2023

@omahane Those linebreaks are in the original. One was intentional the other was not, but both of them were created by the person in the chair, not the export import process.

They arrived because I copied and pasted from the module's readme... which breaks at the 80 character mark.

@swirtSJW
Copy link
Contributor Author

image

@swirtSJW swirtSJW force-pushed the VACMS-15893-set-up-cm-document-import branch from b40edf0 to 2c66f99 Compare October 30, 2023 13:16
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 30, 2023 13:16 Destroyed
@swirtSJW swirtSJW merged commit 7b0df6f into main Oct 30, 2023
13 checks passed
@swirtSJW swirtSJW deleted the VACMS-15893-set-up-cm-document-import branch October 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lay prep work for importing Content Model Documentation.
3 participants