VACMS-15724 Remove archived VC CAPS from VC dashboard.

[swirtSJW]

Description

Relates to #15724

Testing done

Screenshots

Before on left, after on right

UX Review

This ticket has a UX review AC on it but I am not sure of the scope. It changes nothing of the layout or appearance, it simply removes archived facilities from showing in the "Satellite locations" list. Almost anything that is identified is going to be out of scope for this ticket. Anything found should be turned into new issues.

As [email protected]

1. Go to your dashboard

• Give UX eagle eye review.
• Create new issue(s) for anything found.

Accessibility Review

This ticket has a A11y review AC on it but I am not sure of the scope. It changes nothing of the structure, layout or appearance, it simply removes archived facilities from showing in the "Satellite locations" list. Almost anything that is identified is going to be out of scope for this ticket. Anything found should be turned into new issues.

As [email protected]

1. Go to your dashboard

• Give A11y eagle eye review.
• Create new issue(s) for anything found.

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As [email protected]

1. Go to your dashboard
   • Validate that "Scranton Vet Center - SCI Dallas" does not appear in the "Satellite locations" list
   • Validate that "Scranton Vet Center - Waymart" does not appear in the "Satellite locations" list
   • Validate that the "Satellite locations" list contains 13 locations.

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[laflannery]

@swirtSJW I didn't find anything new - all the things I found I already have issues for so this is good to me

[omahane]

Works as designed and meets the first 2 ACs of the parent ticket (the others being dependent on other reviews or additionally identified work).

[thejordanwood]

@swirtSJW This looks good to me and I didn't see any new issues that would require additional tickets.

[swirtSJW]