VACMS-13639: Fixes content lock operation on Reusable Q&A Content Type

[tonytaylor]

Description

The root cause of the issue was the selected widget (Paragraphs(stable)) for the Related Information field. If no value is provided for this field, the form will be forced to re-render up to five times in an effort to resolve the field. The content lock module, however WILL NOT render its messages, unlock button, etc. after the first render attempt. Q&A Records that have a Related Information record present will properly render on the first pass and therefore, not subject to this issue. Changing the widget to Paragraphs Legacy allows for proper operation of the content lock module.

Closes #13639

Testing done

Performed manual testing on ~20 Q&A records w/o Related Information and ~20 Q&A records with it.
Confirmed the This content is now locked by... system message near top of page, as well as the Unlock button near the bottom.
Also, confirmed proper operation -- clicking unlock redirects to Lock Release form.

Screenshots

15637 (Missing Related Information)

47213 (Related Information Populated)

QA steps

What needs to be checked to prove this works?

Navigating to https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/NID/edit substituting NID with a value below should display similar to the screenshots above:

Q&A w/Related Information:
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15710/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15711/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15713/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15718/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15805/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15806/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15807/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15808/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15809/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15855/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15857/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15858/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16009/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16481/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16583/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16584/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16585/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16586/edit

Q&A w/o Related Information:
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15712/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15715/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15803/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15804/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15832/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/15856/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16482/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/16483/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/20486/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/20488/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23233/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23245/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23246/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23248/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23249/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23250/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23251/edit
https://pr15790-g7lgaqxdafmhidbxrj9fq9t1euwnh5tb.ci.cms.va.gov/node/23252/edit

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[ndouglas]

Great detective work! Is this a known issue with Paragraphs?

Do we have any hooks that depend on this being a legacy paragraph?

I did a quick search and I didn't find any references to link_teaser paragraphs that seemed to depend on being a legacy paragraph, or that referred to a q_a node type and depended on being a legacy paragraph. I think this is safe.

Great work!

[jilladams]

@tonytaylor would like to have @chri5tia take a look at this pre-merge if you can afford to wait.

[tonytaylor]

Thanks @ndouglas!

Not a paragraphs expert, but have found widgets to be occasionally fiddly in the past. I believe this is more of a configuration misstep + content lock quirks.

The Paragraphs(stable) widget may be a bit more eager than legacy, which has the form trying to render info that isn't needed in the form. The canary in the coalmine was experiencing form state mutations in debug sessions. I found content lock to do some fairly sus stuff with the one-time render (they have a bail-out clause if $form_state->userInput has data, which can happen if ajax changes the form structure), but at the end of the day, the other widget was actively attempting to transform the link/link_summary part of the form if it was missing, and the legacy widget allows sleeping dogs to lie.

[chri5tia]

Checked view and modal when placing a reusable q&a and checked a single q&a, it all looks good.