Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15779: Set rel="noopener" in preview links. #15780

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

ndouglas
Copy link
Contributor

@ndouglas ndouglas commented Oct 23, 2023

Closes #15779.

Screenshot 2023-10-24 at 10 17 11 AM

QA Steps

  • Find a node view somewhere on the site that has a preview link
  • Verify that the link contains a rel="noopener" attribute.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 23, 2023 13:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 23, 2023 20:07 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2023 14:08 Destroyed
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply brilliant! Well done!

@ndouglas ndouglas merged commit 1ff0f7d into main Oct 24, 2023
15 checks passed
@ndouglas ndouglas deleted the VACMS-15779-Set-rel-noopener-in-preview-links branch October 24, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set rel="noopener" in links that target _blank.
3 participants