VACMS-15503 Add multi workflow filters to all Views that have exposed content moderation filter #15769

swirtSJW · 2023-10-21T03:44:43Z

Description

Relates to #15503

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin go to the following Views and make sure the Moderation state filter is present and works.

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

swirtSJW · 2023-10-21T03:46:09Z

Note to self:

In our multiple workflow pr in #11334
SEE IF IT BROKE (these are not covered by the patch)

/admin/content/promos (uses blocks)
/admin/content/moderated (uses revisions)
admin/content/audit/vamc-top-task-page-revision-histories (uses revisons)
/admin/content/audit/search (uses grouped filter across content types)

swirtSJW · 2023-10-23T13:42:49Z

composer.lock

@@ -10697,8 +10701,8 @@
                    "dev-2.x": "2.x-dev"
                },
                "drupal": {
-                    "version": "8.x-2.0-beta1+4-dev",
-                    "datestamp": "1668804356",
+                    "version": "8.x-2.0-beta2+1-dev",


Unrelated metadata changes.

swirtSJW · 2023-10-23T13:43:46Z

config/sync/views.view.content.yml

          selected_actions:
            -
              action_id: node_save_action
              preconfiguration:
-                add_confirmation: 0
+                add_confirmation: false


Most of these Views have not been changed in a long time so they are going to be full of this kind of noise. Sorry :(

config/sync/views.view.content.yml

swirtSJW · 2023-10-23T13:52:15Z

config/sync/views.view.content.yml

-            editorial-draft: editorial-draft
-            editorial-review: editorial-review
-            editorial-published: editorial-published
-            editorial-archived: editorial-archived


This should have never been limited. It was just outdated.

config/sync/views.view.content.yml

swirtSJW · 2023-10-23T13:53:51Z

config/sync/views.view.content.yml

+              content_publisher: '0'
+              content_admin: '0'
+              redirect_administrator: '0'
+              admnistrator_users: '0'


We have more users than we had when this was last updated. These are expected.

swirtSJW · 2023-10-23T14:29:20Z

config/sync/views.view.content.yml

-            editorial-draft: editorial-draft
-            editorial-review: editorial-review
-            editorial-published: editorial-published
-            editorial-archived: editorial-archived


Incorrectly limited in the old.

config/sync/views.view.content.yml

swirtSJW · 2023-10-23T14:31:07Z

config/sync/views.view.content.yml

-            editorial-draft: editorial-draft
-            editorial-review: editorial-review
-            editorial-published: editorial-published
-            editorial-archived: editorial-archived


Incorrectly limited which was inadvertently hiding "pending appoval" status.

config/sync/views.view.content.yml

config/sync/views.view.facility_services.yml

…ement.

swirtSJW · 2023-10-24T14:18:21Z

I just fixed the two issues @omahane identified. Is rebuilding now.

omahane

This looks great. It's working on all pages.

ndouglas

This looks good to me. Thank you for asking for a review, and sorry about the delay. I need some kind of automated queue to keep track of what I should be doing 🥵

swirtSJW · 2023-10-25T19:08:34Z

va-cms-bot temporarily deployed to Tugboat October 21, 2023 03:44 Destroyed

va-cms-bot temporarily deployed to Tugboat October 21, 2023 04:14 Destroyed

va-cms-bot temporarily deployed to Tugboat October 21, 2023 04:20 Destroyed

va-cms-bot had a problem deploying to Tugboat October 22, 2023 01:34 Error

va-cms-bot temporarily deployed to Tugboat October 22, 2023 01:35 Destroyed

swirtSJW changed the title ~~VACMS-15503 add multi workflow filters to all Views that have exposed content moderation filter~~ VACMS-15503 Add multi workflow filters to all Views that have exposed content moderation filter Oct 23, 2023