VACMS-15422: Makes Vet Center - Outstation names more like Vet Center

[omahane]

Description

Relates to #15422

This PR creates the field on the Vet Center - Outstation and sets the migration configuration and presave to put the official name in the title. After deploy, the new script (scripts/content/VACMS-15422-vet-center-outstation-copy-title.php) will need to be run in production.

Testing done

Manually

Screenshots

node:edit as an admin

node:edit as an editor

QA steps

In the browser

Delete a current Vet Center - Outstation

• As an admin, go to Keene Vet Center Outstation node:edit
• Click Delete
• Confirm deletion

Delete a current Vet Center

• As an admin, go to Henderson Vet Center node:edit
• Click Delete
• Confirm deletion

In the Terminal

Restore "Keene Vet Center Outstation" by migration

• In the terminal, enter the following: drush migrate:import va_node_facility_vet_centers_os --update --idlist=vc_1221OS

Restore "Henderson Vet Center" by migration

• In the terminal, enter the following: drush migrate:import va_node_facility_vet_centers --update --idlist=vc_0534V

In the browser

Verify the "Keene Vet Center Outstation" migration

• As an admin, verify the migration of Keene Vet Center Outstation
  • Confirm that the Name of Vet Center - Oustation is set to "Keene Vet Center Outstation"
  • Confirm that the Common name is set to "Keene Vet Center Outstation"

Verify the "Henderson Vet Center" migration

• As an admin, verify the migration of Henderson Vet Center
  • Confirm that the Name of Vet Center - Oustation is set to "Henderson Vet Center"
  • Confirm that the Common name is set to "Henderson Vet Center"

In the terminal

Update the Vet Center - Outstation names via a script

• In the terminal, enter the following: drush scr ./scripts/content/VACMS-15422-vet-center-outstation-copy-title.php

In the browser

Confirm the Vet Center - Outstation script's changes on previously migrated nodes

• As an admin, go to the Recent log messages.
• Confirm that a log message from Vet Center - Outstation describes updating the nodes.
• Go to Major Brent Taylor Vet Center Outstation
• Confirm that the title is "Major Brent Taylor Vet Center Outstation"
• Confirm that the Vet Center - Outstation name is "Major Brent Taylor Vet Center Outstation"
• Click the Edit tab
• Confirm that the Vet Center - Outstation name is disabled and cannot be edited.
• Confirm that the Common name can be edited by changing the name to "Ogden Vet Center Outstation"
• Save the node
• Confirm that the page title has changed to "Odgen Vet Center Outstation"

Review a Vet Center - Outstation with different common and official names as an editor

• As QA Vet Center Editor, go to Major Brent Taylor Vet Center Outstation
• Confirm that the page title is to "Odgen Vet Center Outstation"
• Click the Edit tab
• Confirm that the Vet Center - Outstation name is disabled and cannot be edited.
• Confirm that the Common name can be edited by changing the name to "Ogden Vet Center Outstation"

Review a Vet Center - Outstation with the same common and official names as an editor

• As QA Vet Center Editor, go to Keene Vet Center Outstation
• Confirm that the page title is "Keene Vet Center Outstation"
• Confirm that the Vet Center - Outstation name is "Keene Vet Center Outstation"
• Click the Edit tab
• Confirm that the Vet Center - Outstation name is disabled and cannot be edited.
• Confirm that the Vet Center - Outstation name is "Keene Vet Center Outstation"
• Confirm that the Common name is not visible (as is expected because the common name and official name is the same)

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[swirtSJW]

This works great. Well done. Great testing steps as always.

[swirtSJW]

Suggested change

	$node_storage = \Drupal::entityTypeManager()->getStorage('node');
	$node_storage = get_node_storage();

Minor: Existing patterns.

[swirtSJW]