VACMS-14215 VAMC mental health phone data push

[swirtSJW]

Description

Relates to #14215

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As QA Content Publisher

1. Test push with no mental health phone Edit this https://pr15688-9qhcwttn1a2ppwra05saolrc3vvoczq4.ci.cms.va.gov/node/2181/edit
2. Change the status and publish the change
   • Go to https://pr15688-9qhcwttn1a2ppwra05saolrc3vvoczq4.ci.cms.va.gov/admin/config/post-api/queue and validate that the push for this facility has no mental health number entry
3. Test push with only API sourced mental health phone: edit this https://pr15688-9qhcwttn1a2ppwra05saolrc3vvoczq4.ci.cms.va.gov/node/2124/edit
4. change nothing and just publish the save.
   • Go to https://pr15688-9qhcwttn1a2ppwra05saolrc3vvoczq4.ci.cms.va.gov/admin/config/post-api/queue and validate that the push for this facility has an entry in the core payload for "mental health phone"
5. Test push with mental health contact (editor sourced) mental health phone: edit the node and for Mental Health Contact phone number enter 555-444-1111
6. Publish and save the node.
   • Go to https://pr15688-9qhcwttn1a2ppwra05saolrc3vvoczq4.ci.cms.va.gov/admin/config/post-api/queue and validate that the push for this facility has an entry in the core payload for "mental health phone" that matches the 555-444-1111 number you entered.

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[swirtSJW]

No phone

API sourced phone

Editor sourced phone

[swirtSJW]

Lighthouse testing thread in Slack

pretty version of the data being sent

[swirtSJW]

Pushed and received without error. The phone number is not processed to anything but at least is not causing a push failure.

[omahane]

I had a bit of a time with the QA steps because the user QA Content Publisher didn't have rights to edit all the nodes, but I made do.

The code worked as expected.

[omahane]

This is very cool.

Not that it's urgent or even necessary, but we have ternary operators around the code that could be refactored with this. This would be cleaner, plus, it would consistently send an empty string. Not sure if we want that, though.

[swirtSJW]

Yah I agree. I think some of the ternaries are fine as they are but this one had to both see if the field exists AND if it had a value. It is also only for strings so it has to be used cautiously.

[swirtSJW]

I had a bit of a time with the QA steps because the user QA Content Publisher didn't have rights to edit all the nodes, but I made do.

Oyy :( Sorry yes I think we need a new QA "person" that has both VAMC roles, because this is impossible to test with with either of out existing QA VAMC roles because one can't publish and the other can't edit.