Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-15649: Adds taxonomy term fields for VBA services #15682

Merged
merged 3 commits into from
Oct 25, 2023
Merged

VACMS-15649: Adds taxonomy term fields for VBA services #15682

merged 3 commits into from
Oct 25, 2023

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Oct 13, 2023 •
edited by swirtSJW
Loading

Description

Relates to #15649

Testing done

Manually

Screenshots

Screenshot 2023-10-17 at 7 24 54 AM

QA steps

Check VBA Facility Service

  • As an admin, create a VBA Facility Service
  • For Section select "Cheyenne VA Regional Benefit Office"
  • For Facility select "Cheyenne VA Regional Benefit Office"
  • For Service name select "Home loans" (which is empty)
    • Confirm that the grey box has no data.
  • For Service name select "Pensions"
  • Confirm that all the fields from the Taxonomy are populating in the grey box
    • Type of care
    • Service description
    • Regional service header
    • Regional service description
    • Facility service header
    • Facility service description
  • Save the Facility service
  • Confirm content in the node:view

Add a service location

  • Edit the VBA Facility Service you just created
  • Add a service location
  • Save
  • Confirm your changes in node:view

Check VAMC System health service

  • Create a VAMC System health service
  • For VAMC system choose "VA Tomah health care"
  • For Section choose choose "VA Tomah health care"
  • For Service name choose "Addiction and substance use care"
  • Confirm that all the fields from the Taxonomy are populating in the grey box
    • Type of care
    • Service description
  • For Service name choose "Adaptive sports"
  • Confirm that all the fields from the Taxonomy are populating in the grey box
    • Type of care
    • Service description
  • Confirm that all the fields from the Taxonomy are populating in the grey box (and no extras)
  • Fill out remaining required fields
  • Save
  • Go back to 'node:edit'
  • For Service name choose "Advice nurse"
  • Confirm that all the fields from the Taxonomy are populating in the grey box
    • Type of care
    • Service description
  • Save

Check VA Services delivery options taxonomy

  • As an admin, visit the taxonomy list
  • Confirm that the "VA Service delivery options" taxonomy is present
  • Confirm that the taxonomy has a description that reads "Single source of truth for service delivery options (e.g. in-person appointments, virtual hotline)"

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 19:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 21:36 Destroyed
@omahane omahane force-pushed the VACMS-15649-add-va-service-taxonomy-fields branch from b3e170c to 112fe8b Compare October 16, 2023 10:53
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2023 10:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2023 15:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2023 11:53 Destroyed
@omahane omahane requested a review from swirtSJW October 17, 2023 12:24
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Oct 17, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2023 04:20 Destroyed
@swirtSJW
Copy link
Contributor

@omahane I am not seeing thiese
image

@omahane omahane force-pushed the VACMS-15649-add-va-service-taxonomy-fields branch from f1ce31d to 7b5b014 Compare October 24, 2023 19:31
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2023 19:31 Destroyed
@omahane omahane changed the base branch from main to integration-service-location October 24, 2023 19:31
@omahane omahane force-pushed the VACMS-15649-add-va-service-taxonomy-fields branch from 7b5b014 to a84dbc1 Compare October 24, 2023 19:40
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2023 19:40 Destroyed
@omahane omahane force-pushed the VACMS-15649-add-va-service-taxonomy-fields branch from a84dbc1 to 015f3e4 Compare October 25, 2023 00:46
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 25, 2023 00:46 Destroyed
@omahane omahane changed the base branch from integration-service-location to main October 25, 2023 00:46
@omahane
Copy link
Contributor Author

omahane commented Oct 25, 2023

I'm trying to add the service delivery options taxonomy to this PR.

swirtSJW
swirtSJW approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests out great. Thank you for adjusting it so it did not need to entangle with the intergration branch. Nice work.
image

image

image

@swirtSJW swirtSJW merged commit d38a023 into main Oct 25, 2023
43 checks passed
@swirtSJW swirtSJW deleted the VACMS-15649-add-va-service-taxonomy-fields branch October 25, 2023 14:30
chri5tia pushed a commit that referenced this pull request Oct 25, 2023
@omahane @chri5tia
VACMS-15649: Adds taxonomy term fields for VBA services (#15682)
21a2e70 
* VACMS-15649: Adds taxonomy term fields for VBA services

* VACMS-15649: Adds revision_log_message back

* VACMS-15649: Adds service delivery options taxonomy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swirtSJW swirtSJW swirtSJW approved these changes

Assignees
No one assigned
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omahane @swirtSJW @va-cms-bot