Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-15647 Add new vamc mental health field. #15679

Merged
merged 2 commits into from
Oct 15, 2023
Merged

VACMS-15647 Add new vamc mental health field. #15679

merged 2 commits into from
Oct 15, 2023

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Oct 13, 2023 •
edited by omahane
Loading

Description

Relates to #15647

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As QA Content Editor

  1. Go to edit a VAMC facility
    • validate that there is the new field "Mental health contact phone number" sitting beneath the Facility API data section and is editable.
    • Validate the field Mental health phone number is in the locked api section and is NOT editable.
  2. Then enter a phone number for "Mental health contact phone number" and save the change as published.
    • Validate that Mental health contact phone number shows up after save.
  3. odds and ends
    • Validate the label for the locked "Phone number" has only P capitalized
    • Validate "Mental health phone number" no longer says "Mental Health Phone"

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 18:43 Destroyed
@github-actions
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@swirtSJW swirtSJW force-pushed the integration-mental-health-phone branch from 2575fc3 to fe8fa5e Compare October 13, 2023 18:44
@swirtSJW swirtSJW force-pushed the VACMS-15647-add-new-vamc-mental-health-field branch from d0130cf to c12a70a Compare October 13, 2023 19:02
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 19:02 Destroyed
@swirtSJW swirtSJW self-assigned this Oct 13, 2023
@swirtSJW swirtSJW requested a review from omahane October 13, 2023 19:29
@swirtSJW swirtSJW marked this pull request as ready for review October 13, 2023 19:29
omahane
omahane requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
Just one change to the instructional text.

config/sync/field.field.node.health_care_local_facility.field_mental_health_contact_phon.yml Outdated
entity_type: node
bundle: health_care_local_facility
label: 'Mental health contact phone number'
description: 'Enter the number Veterans should call to access mental health services at your facility. If your facility doesn''''t offer these services, enter the most appropriate system number. This number will be displayed everywhere your facility appears across VA.gov. <a href="/help/va-medical-centers-vamcs/about-locations-content-for-vamcs/how-to-edit-a-vamc-facility" target="_blank">View guidelines for editing VAMC facilities (opens in a new tab)</a>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Enter the number Veterans should call to access mental health services at your facility. If your facility doesn''''t offer these services, enter the most appropriate system number. This number will be displayed everywhere your facility appears across VA.gov. <a href="/help/va-medical-centers-vamcs/about-locations-content-for-vamcs/how-to-edit-a-vamc-facility" target="_blank">View guidelines for editing VAMC facilities (opens in a new tab)</a>'
description: 'Enter the number Veterans should call to access mental health services at your facility. If your facility doesn'''t offer these services, enter the most appropriate system number. This number will be displayed everywhere your facility appears across VA.gov. <a href="/help/va-medical-centers-vamcs/about-locations-content-for-vamcs/how-to-edit-a-vamc-facility" target="_blank">View guidelines for editing VAMC facilities (opens in a new tab)</a>'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra apostrophe/tic mark in the instructions.
Screenshot 2023-10-13 at 2 47 52 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof but your fix only removes one, it has to remove 2. I can take care of that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, dang. Good catch of my catch.

@swirtSJW swirtSJW force-pushed the VACMS-15647-add-new-vamc-mental-health-field branch from c12a70a to 509cf2d Compare October 13, 2023 20:43
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 20:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2023 20:56 Destroyed
@omahane omahane self-requested a review October 13, 2023 21:21
@swirtSJW swirtSJW force-pushed the VACMS-15647-add-new-vamc-mental-health-field branch from 509cf2d to f9291e2 Compare October 14, 2023 02:05
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 14, 2023 02:05 Destroyed
@swirtSJW swirtSJW force-pushed the integration-mental-health-phone branch from fe8fa5e to 91ed556 Compare October 14, 2023 02:08
@swirtSJW
Revert "VACMS-14213 Make CMS the source of truth for VAMC mental heal…
ce0260e 
…th phone number (#15468)"

This reverts commit 2575fc3.
in order to restore the field location in the api data and its place in the migration.
@swirtSJW
VACMS-15647 Add editable mental health contact field to VAMC facility
ac44e7a
@swirtSJW swirtSJW force-pushed the VACMS-15647-add-new-vamc-mental-health-field branch from f9291e2 to ac44e7a Compare October 14, 2023 02:09
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 14, 2023 02:09 Destroyed
@swirtSJW swirtSJW merged commit cbe6272 into integration-mental-health-phone Oct 15, 2023
12 checks passed
@swirtSJW swirtSJW deleted the VACMS-15647-add-new-vamc-mental-health-field branch October 15, 2023 01:19
swirtSJW added a commit that referenced this pull request Oct 31, 2023
@swirtSJW
VACMS-15647 Add new vamc mental health field. (#15679)
a5577d5 
* Revert "VACMS-14213 Make CMS the source of truth for VAMC mental health phone number (#15468)"

This reverts commit 2575fc3.
in order to restore the field location in the api data and its place in the migration.

* VACMS-15647 Add editable mental health contact field to VAMC facility
swirtSJW added a commit that referenced this pull request Dec 2, 2023
@swirtSJW
VACMS-15647 Add new vamc mental health field. (#15679)
c1bb433 
* Revert "VACMS-14213 Make CMS the source of truth for VAMC mental health phone number (#15468)"

This reverts commit 2575fc3.
in order to restore the field location in the api data and its place in the migration.

* VACMS-15647 Add editable mental health contact field to VAMC facility
swirtSJW added a commit that referenced this pull request Jan 16, 2024
@swirtSJW
VACMS-9717 Make CMS the source of truth for VAMC mental health phone (#…
51a8473 
…15585)

* VACMS-14213 Make CMS the source of truth for VAMC mental health phone number (#15468)

* VACMS-14213 Move VAMC mental health number to editable region.

* VACMS-14213 Remove Mental health phone number from VACMS facility migration.

* VAMC-14213 Updated help text.

* VACMS-14213 Change phone field labels to title case.

* VACMS-15647 Add new vamc mental health field. (#15679)

* Revert "VACMS-14213 Make CMS the source of truth for VAMC mental health phone number (#15468)"

This reverts commit 2575fc3.
in order to restore the field location in the api data and its place in the migration.

* VACMS-15647 Add editable mental health contact field to VAMC facility

* Add sample phone number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omahane omahane Awaiting requested review from omahane

Assignees

@swirtSJW swirtSJW

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swirtSJW @omahane @va-cms-bot