Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15617: Fix composer.lock check. #15618

Closed
wants to merge 3 commits into from

Conversation

ndouglas
Copy link
Contributor

@ndouglas ndouglas commented Oct 10, 2023

Description

Relates to #issueid. (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2023 13:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 14, 2023 13:16 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 14, 2023 13:17 Destroyed
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2024 18:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 21, 2024 21:08 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 4, 2024 18:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 16:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 19:12 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 18:48 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants