Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15597 Add field_diagram to CMDocument. #15600

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Oct 9, 2023

Description

Closes #15597

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin

  1. Edit an existing Content Model Document.

  2. Under the Diagram field fill in the following fields.

    • Title Communication breakdown
    • Mermaid diagram
    sequenceDiagram
     Christian->>+Steve: Hello Steve, how are you?
     Christian->>+Steve: Steve, can you hear me?
     Steve-->>-Christian: Hi, I can hear you!
     Steve-->>-Christian: I feel great!
     Christian->>+Dave: Dave, can you hear me?
     Dave->>+Steve: Can you tell Christian I can hear him.
     Steve->>+Dave: I'm a developer not an telephone operator.
     Dave->>+Christian: I think Steve needs more fiber.
    
    • Caption Dave theorizes that All-bran buds would be a good gift.
  3. Save the document

    • Validate that you see the diagram and caption.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@swirtSJW swirtSJW added the Facilities Facilities products (VAMC, Vet Center, etc) label Oct 9, 2023
@swirtSJW swirtSJW self-assigned this Oct 9, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 9, 2023 18:31 Destroyed
@swirtSJW swirtSJW requested a review from omahane October 9, 2023 20:00
@swirtSJW swirtSJW marked this pull request as ready for review October 9, 2023 20:01
@swirtSJW
Copy link
Contributor Author

swirtSJW commented Oct 9, 2023

The necessary module has already landed on prod so this can be merged whenever.

Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I love the example diagram.
https://www.youtube.com/watch?v=2atkj_KWLl0

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Oct 9, 2023

image

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 9, 2023 21:44 Destroyed
@swirtSJW swirtSJW merged commit defd282 into main Oct 9, 2023
13 checks passed
@swirtSJW swirtSJW deleted the VACMS-15597-add-diagram-field-cmdocument branch October 9, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add field_diagram to CMDocument entity so diagrams can be used in documentation
3 participants