Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15595 Bump content model documentation and config dependency #15596

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Oct 9, 2023

Description

closes #15595

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As an admin

  1. Go to Enabled module report
    • Validate you see Mermaid Diagram Field in the list
  2. Then got to User report
    • Validate that mermaid charts show without errors.
  3. Then got to Workflow diagram
    • Validate that mermaid chart shows without errors.
  4. Then go to Entity reference diagram
    • Validate the diagram shows without errors.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 9, 2023 14:23 Destroyed
@swirtSJW swirtSJW self-assigned this Oct 9, 2023
@swirtSJW swirtSJW requested a review from omahane October 9, 2023 14:41
@swirtSJW swirtSJW marked this pull request as ready for review October 9, 2023 14:44
@swirtSJW swirtSJW enabled auto-merge (squash) October 9, 2023 14:47
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!
Screenshot 2023-10-09 at 10 12 40 AM
Screenshot 2023-10-09 at 10 12 48 AM
Screenshot 2023-10-09 at 10 12 55 AM

@swirtSJW swirtSJW merged commit c59ac4c into main Oct 9, 2023
21 checks passed
@swirtSJW swirtSJW deleted the VACMS-15595-bump-content_model_documentation-and-config-dependency branch October 9, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Content Model Documentation and configure Mermaid Diagram Field dependency
3 participants