VACMS-14342: Set up `CODEOWNERS` #15581

ndouglas · 2023-10-06T13:04:26Z

This includes a CODEOWNERS file (I hope it works) and some light documentation about the concept.

I am posting this and requesting a review from basically everyone on this project in the interests of transparency (and, most likely, catching stupid mistakes arising directly from my ignorance and various moral failings).

This is a total work in progress. I ask – I beg – for y'all to review this and give input and feedback. Obv fixing it after this point is just a matter of opening a pull request, but I want to ensure that everyone feels that this file matches the current state and goals of the project as a whole and our respective teams and is not something I'm yeeting into the codebase by fiat.

FAQ

Why do you have so many lines with `# @department-of-veterans-affairs/platform-cms-drupal-engineers`?

The # makes it a comment. That line's intended to indicate that platform-cms-drupal-engineers is the default code owner, but still mention that directory/file so that we can discuss it.

In some cases, I may have suggested that platform-cms-drupal-engineers would own something they shouldn't. This is purely a result of ignorance on my part. So I'm adding these lines in an effort to be as transparent as possible, and because I'm seeking feedback.

What are these new groups? Whoever heard of `platform-cms-qa`, anyway?

The platform-cms teams are newly added, as of yesterday. I'm adding platform-cms-ux, platform-cms-accessibility, etc teams to ensure that we have a formal way of requesting review from our UX and Accessibility experts.

The full list of new teams can be found here:

These teams are my best approximations of the different disciplinary areas within the Platform Team. It's possible I left something or someone out. I'm sorry, folks, I'm doing the best I can.

Hey, you did a dumb over here!

Sorry, I'll fix it 😓

Have you heard about `$coolTool` or `$coolProcess` we can use with CODEOWNERS?

Nope. Pls tell me about it.

That formatting is WACK.

I was trying to make things easier to read and less like a wall of text. IDK if it's actually helping, though.

EWashb · 2023-10-06T13:49:22Z

The only thing I have to add to this amazing work is that it might be helpful to add @joagnitti to the UX team. She may not always have a review to give, though.

Thank you for doing this, Nate!

.github/CODEOWNERS

jilladams · 2023-10-06T15:44:31Z

.github/CODEOWNERS

 # @department-of-veterans-affairs/cms-infrastructure
+# @department-of-veterans-affairs/facilities-cms
+# @department-of-veterans-affairs/public-websites-cms
 # @department-of-veterans-affairs/vfs-cms-team


Noting: this team is primarily administrative, and used to govern access to the va.gov-cms repo, mainly so ppl can access the sprint board and make tickets in here, but it includes all kinds of random people (PMs, DMs, Researchers, etc). I know this is a code comment is that worth adding, so no one tries to make this group a codeowner of anything? I could go either way. 🤷‍♀️

Good question. I thought it might be a good fallback, but perhaps it's not. I could also just use all of the existing teams if there's no good reason for a specific one to get requests.

jilladams · 2023-10-06T15:46:32Z

.github/CODEOWNERS

+/bin/                                                               @department-of-veterans-affairs/platform-cms-devops-engineers
+
+# Config belongs to everyone, because I haven't figured out a way for this not to be a pain in the butt.
+/config/                                                            @department-of-veterans-affairs/vfs-cms-team


Related to my comment above. 😬 Do we need a "platform-cms-contributors" team or something that is only engineers? That is annoying and probably wrong, if I'm thinking about how new Drupal contributor teams will get onboarded (would mean adding them to both vfs-cms-team for access, as well as the code contrib team, for PR review purposes.).

Whatever's easiest. If everyone gets vfs-cms-team, then that's fine IMHO and probably for most everyone. I'm not worried about people maliciously editing anything, and the lower the friction, the better.

.github/CODEOWNERS

jilladams · 2023-10-06T15:54:32Z

Added Sitewide Drupal folks as reviewers, @swirtSJW @omahane @dsasser @chri5tia. Would love to make sure that custom code y'all have written / added to, and any files you touch regularly / feel we should own, are listed correctly. This is not urgent, so feel free to save it for after your sprint work is wrapped. If we need to budget time in next sprint to dive deeper, we can discuss at planning.

.github/CODEOWNERS

dsasser

PW is the codeowner of the Forms migration, so should be a 2nd owner of va_gov_migrate

.github/CODEOWNERS

swirtSJW

This is a great compilation @ndouglas. Very thorough.

There are a couple places where I think co-ownership might be warranted. see comments.

.github/CODEOWNERS

@swirtSJW

h/t @swirtSJW

Fixed.

acrollet · 2023-10-31T13:17:59Z

Have you heard about $coolTool or $coolProcess we can use with CODEOWNERS?

well, since you asked... https://github.com/andrewring/github-distributed-owners

@swirtSJW

* VACMS-14342: Set up CODEOWNERS * h/t Dave * h/t Tanner * h/t Dave * Update .github/CODEOWNERS * Apply suggestions from code review h/t @swirtSJW

@swirtSJW

…#15936) * gitignore public/private key for oauth * export config for simple_oauth and next js site * use simple oauth for preview in next * echo keys to files in tugboat * add other env vars where they need to be * [docs] Update and rename pw-dark-launch.md to dark-launch.md * Bump datadog/dd-trace from 0.92.2 to 0.93.1 (#15937) Bumps [datadog/dd-trace](https://github.com/DataDog/dd-trace-php) from 0.92.2 to 0.93.1. - [Release notes](https://github.com/DataDog/dd-trace-php/releases) - [Commits](DataDog/dd-trace-php@0.92.2...0.93.1) --- updated-dependencies: - dependency-name: datadog/dd-trace dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * VACMS-14342: Set up `CODEOWNERS` (#15581) * VACMS-14342: Set up CODEOWNERS * h/t Dave * h/t Tanner * h/t Dave * Update .github/CODEOWNERS * Apply suggestions from code review h/t @swirtSJW * Bump va-gov/content-build from 0.0.3377 to 0.0.3378 (#15938) Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3377 to 0.0.3378. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3377...v0.0.3378) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * VACMS-15721: added description field for alert blocks view and browser (#15927) * VACMS-15276: Adds YouTube field (#15450) * VACMS-15276: Adds YouTube field * VACMS-15276: Adding field storage for YouTube * VACMS-15891: Update Q&A Content Report View to use Multiple Workflow Filter (#15896) * VACMS-15891: Update workflow filter to multiple * VACMS-15891: Updated the filter machine name too because Jill is smart. * VACMS-15891: Style-Guide-Related edits to view * VACMS-15891: Added section filter * VACMS-15891: Fix caption * VACMS-15891: Caption and tab * VACMS-15891: Copying new settings from view family * VACMS-15891: Fix pager back to 25 for cypress test * update perms for nextjs role * update perms for nextjs role * re-export config for correct dependencies * override config for tugboat * include full domains in the url path... * a couple more env vars in place * env vars need added before build * tweak env vars slightly * quote env vars --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jill Adams <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nate Douglas <[email protected]> Co-authored-by: Edmund Dunn <[email protected]> Co-authored-by: Christian Burk <[email protected]> Co-authored-by: Christia Troyer <[email protected]>

VACMS-14342: Set up CODEOWNERS

3631ac5

va-cms-bot temporarily deployed to Tugboat October 6, 2023 13:04 Destroyed

davidmpickett reviewed Oct 6, 2023

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

h/t Dave

09d0e5a

va-cms-bot temporarily deployed to Tugboat October 6, 2023 14:25 Destroyed

tjheffner reviewed Oct 6, 2023

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

h/t Tanner

f859ef8

va-cms-bot temporarily deployed to Tugboat October 6, 2023 14:55 Destroyed

jilladams reviewed Oct 6, 2023

View reviewed changes

jilladams requested review from dsasser, omahane, swirtSJW and chri5tia October 6, 2023 15:51

davidmpickett reviewed Oct 6, 2023

View reviewed changes

.github/CODEOWNERS Show resolved Hide resolved

h/t Dave

05fe0c3

va-cms-bot temporarily deployed to Tugboat October 6, 2023 16:07 Destroyed

dsasser previously requested changes Oct 11, 2023

View reviewed changes

ndouglas commented Oct 11, 2023

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Update .github/CODEOWNERS

f1b6372

va-cms-bot temporarily deployed to Tugboat October 11, 2023 17:53 Destroyed

Merge branch 'main' into VACMS-14342-Set-up-CODEOWNERS

c6b85c1

va-cms-bot temporarily deployed to Tugboat October 11, 2023 18:36 Destroyed

swirtSJW reviewed Oct 18, 2023

View reviewed changes

Apply suggestions from code review

e90a82d

h/t @swirtSJW

va-cms-bot had a problem deploying to Tugboat October 24, 2023 15:31 Error

Merge branch 'main' into VACMS-14342-Set-up-CODEOWNERS

0438bdf

va-cms-bot temporarily deployed to Tugboat October 24, 2023 15:32 Destroyed

Merge branch 'main' into VACMS-14342-Set-up-CODEOWNERS

c478d34

va-cms-bot temporarily deployed to Tugboat October 30, 2023 12:35 Destroyed

ndouglas marked this pull request as ready for review October 30, 2023 12:35

Merge branch 'main' into VACMS-14342-Set-up-CODEOWNERS

998b65c

va-cms-bot temporarily deployed to Tugboat October 31, 2023 13:07 Destroyed

ndouglas merged commit 4c46a5b into main Nov 1, 2023
14 checks passed

ndouglas deleted the VACMS-14342-Set-up-CODEOWNERS branch November 1, 2023 12:27

tjheffner pushed a commit that referenced this pull request Nov 2, 2023

VACMS-14342: Set up CODEOWNERS (#15581)

65d6b69

* VACMS-14342: Set up CODEOWNERS * h/t Dave * h/t Tanner * h/t Dave * Update .github/CODEOWNERS * Apply suggestions from code review h/t @swirtSJW

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-14342: Set up `CODEOWNERS` #15581

VACMS-14342: Set up `CODEOWNERS` #15581

ndouglas commented Oct 6, 2023 •

edited

Loading

EWashb commented Oct 6, 2023

jilladams Oct 6, 2023

ndouglas Oct 6, 2023

jilladams Oct 6, 2023

ndouglas Oct 6, 2023

jilladams commented Oct 6, 2023

dsasser left a comment

swirtSJW left a comment

acrollet commented Oct 31, 2023

VACMS-14342: Set up CODEOWNERS #15581

VACMS-14342: Set up CODEOWNERS #15581

Conversation

ndouglas commented Oct 6, 2023 • edited Loading

FAQ

Why do you have so many lines with # @department-of-veterans-affairs/platform-cms-drupal-engineers?

What are these new groups? Whoever heard of platform-cms-qa, anyway?

Hey, you did a dumb over here!

Have you heard about $coolTool or $coolProcess we can use with CODEOWNERS?

That formatting is WACK.

EWashb commented Oct 6, 2023

jilladams Oct 6, 2023

Choose a reason for hiding this comment

ndouglas Oct 6, 2023

Choose a reason for hiding this comment

jilladams Oct 6, 2023

Choose a reason for hiding this comment

ndouglas Oct 6, 2023

Choose a reason for hiding this comment

jilladams commented Oct 6, 2023

dsasser left a comment

Choose a reason for hiding this comment

swirtSJW left a comment

Choose a reason for hiding this comment

acrollet commented Oct 31, 2023

VACMS-14342: Set up `CODEOWNERS` #15581

VACMS-14342: Set up `CODEOWNERS` #15581

ndouglas commented Oct 6, 2023 •

edited

Loading

Why do you have so many lines with `# @department-of-veterans-affairs/platform-cms-drupal-engineers`?

What are these new groups? Whoever heard of `platform-cms-qa`, anyway?

Have you heard about `$coolTool` or `$coolProcess` we can use with CODEOWNERS?