Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15308 Update color variables in CSS #15560

Closed
wants to merge 13 commits into from

Conversation

edmund-dunn
Copy link
Contributor

Description

Relates to #15308

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Review colors and a11y per #15309

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn linked an issue Oct 5, 2023 that may be closed by this pull request
6 tasks
@edmund-dunn edmund-dunn self-assigned this Oct 5, 2023
@edmund-dunn edmund-dunn added CMS design CMS Team CMS Product team that manages both editor exp and devops labels Oct 5, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2023 15:42 Destroyed
Copy link
Contributor

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tested quite a few pages and no color contrast issues are being flagged so this looks good to me.

@ndouglas
Copy link
Contributor

ndouglas commented Nov 6, 2023

@edmund-dunn Any particular reason this hasn't been merged yet? 🤔

@BlakeOrgan
Copy link
Contributor

@ndouglas I am reviewing this as part of #15309 before merging.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:27 Destroyed
@gracekretschmer-metrostar

Pull up for sprint 22 and bring in Amanda and Marisa.

@JakeBapple
Copy link
Contributor

Strategy:
new branch from main using 15308 naming
merge in 15308 and then 14753
run the storybook styles and then the theme command to check for errors
tag edmund, steve, and marissa for review
can close those two after we merge in the new one

@JakeBapple
Copy link
Contributor

closing this pr as it was consolidated in this: #19520

@JakeBapple JakeBapple closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS design CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color variables in CSS
8 participants