Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15471 Implement Snyk security scanning #15487

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

edmund-dunn
Copy link
Contributor

Description

Relates to #15471

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  • Passes automated testing.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn linked an issue Oct 2, 2023 that may be closed by this pull request
7 tasks
@edmund-dunn edmund-dunn self-assigned this Oct 2, 2023
@edmund-dunn edmund-dunn requested a review from ndouglas October 2, 2023 17:19
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops DevOps CMS team practice area labels Oct 2, 2023
@edmund-dunn edmund-dunn added the Drupal engineering CMS team practice area label Oct 2, 2023
@edmund-dunn edmund-dunn enabled auto-merge (squash) October 2, 2023 17:21
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2023 17:21 Destroyed
@edmund-dunn edmund-dunn disabled auto-merge October 2, 2023 17:55
@edmund-dunn edmund-dunn merged commit 03660bc into main Oct 2, 2023
14 checks passed
@edmund-dunn edmund-dunn deleted the 15471-implement-snyk-security-scanning branch October 2, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops DevOps CMS team practice area Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Snyk security scanning
3 participants