Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15088: Removes the covid_url from payload #15466

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Sep 29, 2023

Description

Relates to #15088

Testing done

Manually

Screenshots

Comparison of current output and PR output

Screenshot 2023-09-29 at 9 47 45 AM

QA steps

Clear the queue

  • In terminal, run drush queue:delete post_api_queue
  • Run drush queue:list
  • Confirm that the post_api_queue is empty

CMS QA

LIghthouse QA

  • Coordinate with Lighthouse to validate that the record to be sent in the test environment is ingested without error
  • Process the queue
  • Confirm with Lighthouse that 1 record was sent and ingested without error

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 29, 2023 14:52 Destroyed
@omahane omahane requested a review from swirtSJW September 29, 2023 14:53
@github-actions github-actions bot added DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc) labels Sep 29, 2023
@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 3, 2023

Confirmed with lighthouse that the push is received fine.

@swirtSJW swirtSJW force-pushed the VACMS-15088-remove-covid-url branch from 53a6a9b to 3e3fbec Compare October 3, 2023 16:24
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2023 16:24 Destroyed
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out great with Lighthouse and here
image

@swirtSJW swirtSJW added VAMC CMS managed product owned by Facilities team COVID-19 COVID-19 related and removed DO NOT MERGE Do not merge this PR labels Oct 3, 2023
@swirtSJW swirtSJW merged commit 4cbb71b into main Oct 3, 2023
@swirtSJW swirtSJW deleted the VACMS-15088-remove-covid-url branch October 3, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COVID-19 COVID-19 related Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants