Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-000 Remove Pittsburgh VAMC as default value on VAMC operating status node #15464

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

davidmpickett
Copy link
Contributor

@davidmpickett davidmpickett commented Sep 28, 2023

Description

Currently when a user goes to create a new VAMC System Operating Status, the VAMC system field defaults to VA Pittsburgh. This is a legacy configuration from VAMC pilot. This should default to none.

Screenshots

Screenshot 2023-09-28 172921

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2023 22:39 Destroyed
@davidmpickett davidmpickett added VAMC CMS managed product owned by Facilities team Facilities Facilities products (VAMC, Vet Center, etc) labels Sep 28, 2023
@davidmpickett
Copy link
Contributor Author

Verified on tugboat that the default is correctly showing up
Screenshot 2023-09-28 175020

@swirtSJW swirtSJW added the Drupal engineering CMS team practice area label Sep 29, 2023
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done Mr Pickett.

@swirtSJW
Copy link
Contributor

swirtSJW commented Sep 29, 2023

This is a good fix. We don't have an issue against this, so I'll note the scope here. It is important to note that no editor has the option to add this page
image

These would only be created by an admin or content-admin when we stand up a new system. These were all originally created by the VAMC upgrade team.

@davidmpickett first config contribution should be celebrated though. 🕺

Approved but won't merge until monday.

@swirtSJW swirtSJW changed the title removing Pittsburgh VAMC as default value on VAMC operating status VACMS-000 Remove Pittsburgh VAMC as default value on VAMC operating status node Sep 29, 2023
@davidmpickett davidmpickett enabled auto-merge (squash) October 2, 2023 16:32
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2023 16:34 Destroyed
@davidmpickett davidmpickett merged commit 8387fed into main Oct 2, 2023
14 checks passed
@davidmpickett davidmpickett deleted the clear_default_VAMC_system_operating_staus branch October 2, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants