Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-9919: Fixes visual focus styles on node edit form unlock button #15441

Merged
merged 2 commits into from
Sep 28, 2023
Merged

VACMS-9919: Fixes visual focus styles on node edit form unlock button #15441

merged 2 commits into from
Sep 28, 2023

Conversation

tonytaylor
Copy link
Contributor

@tonytaylor tonytaylor commented Sep 28, 2023 •
edited by edmund-dunn
Loading

Description

Adds a11y-friendly visual indication styles to the "Unlock" button located on node edit forms.

Relates to #9919

Screenshots

20230927_2022--visual-focus-style-on-node-edit-form-unlock-button

QA steps

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2023 01:03 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Sep 28, 2023
@laflannery
Copy link
Contributor

Looks good!

edmund-dunn
edmund-dunn approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2023 18:15 Destroyed
@tonytaylor tonytaylor merged commit b3d4756 into department-of-veterans-affairs:main Sep 28, 2023
@tonytaylor tonytaylor deleted the VACMS-9919-fixes-visual-focus-on-node-edit-unlock-button branch September 28, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmund-dunn edmund-dunn edmund-dunn approved these changes

Assignees
No one assigned
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonytaylor @laflannery @edmund-dunn @va-cms-bot