Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-11230: Follow up to remove debugging code #15421

Merged

Conversation

chri5tia
Copy link
Contributor

Description

Relates to #11230

Previous PR left a line of debugging code that prints an integer to the screen when the alert block is placed. It's very small and we didn't catch it during testing.

Testing done

Local, functional.

Screenshots

Screenshot 2023-09-26 at 10 43 27 PM

QA steps

As a user with any role, edit any benefit detail page and place an unpublished alert block. Ensure that an integer is not placed on the screen as shown in the screenshot.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 27, 2023 05:46 Destroyed
@chri5tia chri5tia added the Public Websites Scrum team in the Sitewide crew label Sep 27, 2023
@chri5tia chri5tia merged commit 47a2093 into main Sep 27, 2023
15 checks passed
@chri5tia chri5tia deleted the VACMS-11230-Unpublished-Alerts-Styling-Remove-Debuggin branch September 27, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants