Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Add and enable filter_perms module. #15409

Closed
wants to merge 1 commit into from

Conversation

timcosgrove
Copy link
Contributor

Description

Relates to #issueid. (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@timcosgrove timcosgrove added the DO NOT MERGE Do not merge this PR label Sep 26, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 26, 2023 20:17 Destroyed
@timcosgrove timcosgrove force-pushed the VACMS-15407-filter_perms branch from 6a7664a to 68fe4dc Compare September 26, 2023 20:20
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 26, 2023 20:20 Destroyed
@ndouglas ndouglas marked this pull request as draft September 27, 2023 16:15
@ndouglas
Copy link
Contributor

(Converted draft to mechanically prevent merge.)

@timcosgrove timcosgrove closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants