Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-0000: Resync stray config changes to code #15293

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

chri5tia
Copy link
Contributor

@chri5tia chri5tia commented Sep 18, 2023

Description

No ticket.

This PR resyncs some straggling database changes back to code. Most of them appear to just be weight changes/re-order of fields and data elements.

Testing done

Some in-browser functional testing.

Screenshots

n/a

QA steps

Take a look at the code syncs and make sure nothing seems amiss. No functionality of the site should have changed.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2023 22:27 Destroyed
@chri5tia chri5tia requested a review from swirtSJW September 18, 2023 22:29
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all make sense. Largely outputing format changes. All good.

@swirtSJW swirtSJW changed the title VAGOV-0000: Resync stray config changes to code VACMS-0000: Resync stray config changes to code Sep 18, 2023
@swirtSJW swirtSJW enabled auto-merge (squash) September 18, 2023 22:31
@swirtSJW
Copy link
Contributor

Thanks for taking this on @chri5tia. That is a big help.

@swirtSJW swirtSJW added the Drupal engineering CMS team practice area label Sep 18, 2023
@swirtSJW swirtSJW merged commit 09ce8af into main Sep 18, 2023
17 checks passed
@swirtSJW swirtSJW deleted the VACMS-0000-Resync-Code-Config-Changes branch September 18, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants