Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15287: upgrade storybook #15289

Merged
merged 2 commits into from
Sep 18, 2023
Merged

VACMS-15287: upgrade storybook #15289

merged 2 commits into from
Sep 18, 2023

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Sep 18, 2023

Description

Closes #15287.

Testing done

Ran server locally, compiled theme locally and compiled storybook locally. All successful.

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Go the storybook
    • Validate that it is accessible
  2. Then
    • Validate that is is on version 7.4.2.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn linked an issue Sep 18, 2023 that may be closed by this pull request
7 tasks
@edmund-dunn edmund-dunn self-assigned this Sep 18, 2023
@edmund-dunn edmund-dunn added the CMS Team CMS Product team that manages both editor exp and devops label Sep 18, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2023 15:58 Destroyed
Copy link
Contributor

@ndouglas ndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

Screenshot 2023-09-18 at 12 43 54 PM

@ndouglas ndouglas merged commit 437999c into main Sep 18, 2023
17 checks passed
@ndouglas ndouglas deleted the 15287-upgrade-storybook branch September 18, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade storybook
3 participants