Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the editor UX by adding link to VBA Facility Service workflow from the VBA facility node #17885

Closed
3 tasks done
davidmpickett opened this issue Apr 17, 2024 · 10 comments
Closed
3 tasks done
Assignees
Labels
Content CMS team practice area Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide UX

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Apr 17, 2024

If at all possible, we should improve the editor UX slightly by adding more support via navigation to the VBA Facility Service workflow from the VBA facility node before staging review

  • i.e., Replace "Facility services are created on a different page." with "Add or edit Facility services [here](VBA service link)"

68747470733a2f2f7a682d66696c652d70726f64756374696f6e2d707269766174652e73332e616d617a6f6e6177732e636f6d2f7675397370766f6a706962726f71386c78766f726f6c37757162666f3f726573706f6e73652d636f6e74656e742d646973706f736974696f6e3d696e6c696e6525334225

Originally posted by @mmiddaugh in #16268 (comment)

Plan

This is an interim plan. Eventually we want to adopt the paradigm we will be using for Vet Center Facility Services out of #17708.

ACs

@davidmpickett davidmpickett added Facilities Facilities products (VAMC, Vet Center, etc) Drupal engineering CMS team practice area Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team labels Apr 17, 2024
@davidmpickett
Copy link
Contributor Author

Once #18003 is complete, we might be able to port that interface to VBA

@jilladams jilladams added UX and removed Needs refining Issue status labels May 23, 2024
@jilladams jilladams added the Content CMS team practice area label Jun 26, 2024
@jilladams
Copy link
Contributor

Stopgap still has value to Editrors in the interim

@omahane
Copy link
Contributor

omahane commented Jul 1, 2024

The solution will be something like how it is for nonclinical:

  • field.field.node.vha_facility_nonclinical_service.field_administration.yml
  epp:
    value: '[current-page:query:field_administration]'

@omahane
Copy link
Contributor

omahane commented Jul 2, 2024

@davidmpickett Is this language sufficient for these links:

Facility services
To create a facility service, visit the add VBA facility service form.

To see all services for this facility, visit the content search page (filtered for services of this facility).

Screenshot 2024-07-02 at 1 04 07 PM

@davidmpickett
Copy link
Contributor Author

davidmpickett commented Jul 2, 2024

@omahane
Copy link
Contributor

omahane commented Jul 2, 2024

Got it.
Screenshot 2024-07-02 at 2 56 56 PM

@davidmpickett
Copy link
Contributor Author

Verified on prod!

Screenshot 2024-07-03 at 5 36 10 PM

@jilladams
Copy link
Contributor

The new links are working, but there's a weird behavior happening related to this issue where the "cant' find what you're looking for" section is also strangely linking to the facility service area. Visible on Tugboat here:
https://main-2pegzvqcy77ynmcultaityqtlrpfbfoo.demo.cms.va.gov/node/4105/edit#undefined

@omahane
Copy link
Contributor

omahane commented Jul 15, 2024

@jilladams @Agile6MSkinner I see what happened here. I've got a PR for this: #18509

@omahane
Copy link
Contributor

omahane commented Jul 18, 2024

Screenshot 2024-07-18 at 8 46 39 AM
Verified on prod.

@Agile6MSkinner @davidmpickett This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content CMS team practice area Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide UX
Projects
None yet
Development

No branches or pull requests

4 participants