Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consider] Support custom Help Text on Link fields controlled by Linkit Module #17201

Open
6 tasks
davidmpickett opened this issue Feb 9, 2024 · 3 comments
Open
6 tasks
Labels
CMS Team CMS Product team that manages both editor exp and devops Enhancement Issue type: New feature or request Needs Analysis Needs to reviewed by Product or Delivery before moving to backlog Needs refining Issue status UX debt Known issues with the user experience

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Feb 9, 2024

User Story or Problem Statement

As a UXer designing editorial interfaces in the Drupal CMS, I need to customize help text so I can make it relevant to the user's context.

Right now if I try to provide custom help text on a Link field that is using the LinkIt widget it won't show up on the interface. The default help text from the LinkIt module is shown instead.

Screenshot 2024-02-06 at 2 03 47 PM

The Facilities Team discovered this while working on #16327. @omahane created an upstream issue on the Drupal Module.

Acceptance Criteria

  • Testable_Outcome_X
  • Testable_Outcome_Y
  • Testable_Outcome_Z
  • Requires Content Model Documentation
  • Requires design review
  • Requires KB article update

Implementation steps

Design principles

@davidmpickett davidmpickett added Enhancement Issue type: New feature or request Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops UX debt Known issues with the user experience labels Feb 9, 2024
@xiongjaneg xiongjaneg added the Needs Analysis Needs to reviewed by Product or Delivery before moving to backlog label Feb 9, 2024
@omahane
Copy link
Contributor

omahane commented Feb 10, 2024

@davidmpickett I created a merge request on the upstream issue. I would like to get your feedback there, if possible.

@omahane
Copy link
Contributor

omahane commented Feb 12, 2024

If we decide we want this and use a patch, we'll need to check for any links that may be overridden currently, such as field_url_of_an_online_event, which is currently overridden in EntityEventSubscriber: va_gov_events/src/EventSubscriber/EntityEventSubscriber.php

@davidmpickett
Copy link
Contributor Author

@davidmpickett I created a merge request on the upstream issue. I would like to get your feedback there, if possible.

Feedback added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Enhancement Issue type: New feature or request Needs Analysis Needs to reviewed by Product or Delivery before moving to backlog Needs refining Issue status UX debt Known issues with the user experience
Projects
None yet
Development

No branches or pull requests

3 participants