Update VBA Facility post-review and collab cycle feedback

[xiongjaneg]

Description or Additional Context

VBA Facility content type was reviewed by UX in #14888.
Collab cycle feedback was reveiwed by UX in 15989

Recommendations are documented in Figma.

Character counter and error states updates are covered under separate tickets.

Acceptance Criteria

• Review Figma for updates and annotations. Consult Jordan as needed.
• VBA Facility updates are made according to Figma.
  • The order of many fields has shifted from current design to new design
  • Text under Editing this Content has changed
  • Jump to edit renamed to On this page
  • Operating status fieldset
    • Is now part of Location and contact information fieldset
    • Text under operating status section says "This status will display on the facility's page and in VA's facility locator tool."
    • Help text under Operating status Details says "Add relevant details about how this status will impact Veterans and visitors."
  • Banner alert
    • Links in help text have been linked properly (See comment below for screenshot/details)
      • [VA Design System (opens in a new window)] links to https://design.va.gov/components/banner/
      • [Knowledge Base (opens in a new window)]links to https://prod.cms.va.gov/help/veterans-benefits-administration-vba/banner-alerts
  • Top of page information fieldset
    • Page introduction field is removed from content type
    • This fieldset is removed
  • Facility Image fieldset
    • Renamed from Facility photo
    • Is now part of Location and contact information fieldset
    • New text guidance added
  • Location and contact information fieldset
    • This fieldset now includes both editable (Operating Status & Facility photo) and non-editable fieldsets
    • This fieldset should now be a collapsable accordion
    • The order of fields in the non-editable fieldset has shifted
      • Benefit office hours may vary fetch field is now included here
      • Benefits hotline fetch field is now included here
      • Db data has been renamed Facility CMS data and has explanatory text
  • Prepare for your visit fieldset
    • This fieldset should now be a collapsable accordion
    • Initial text has changed
    • Accordion / Header help text has changed
  • Spotlight content fieldset
    • This fieldset should now be a collapsable accordion
    • Spotlight call to action link text help text should go to https://design.va.gov/content-style-guide/links#link-text
    • Why can't I edit this bubble on National spotlight should say "This content is standardized to provide consistent messaging for facilities nationwide."
  • Facility services = brand new tooltip
  • Other VA locations = brand new tooltip
• Requires design review
• Requires accessibility review

Team

Please check the team(s) that will do this work.

• CMS Team
• Public Websites
• Facilities
• Accelerated Publishing

[davidmpickett]

Current design VBA_Facility_Current.pdf

[davidmpickett]

New design
VBA_Facility_new.pdf.zip

[davidmpickett]

@omahane @swirtSJW @thejordanwood
I updated the ticket with a lot more details of the updates between the current and new design. I did not spell out every single detail, but this should be a pretty good guide

[laflannery]

In the banner alert section there are 2 links in the help text that do not currently work, they are just refreshing the current page. Can these be updated?

[omahane]

@davidmpickett The changes to the design would change the header and content help text for all Accordions. I want to confirm that this is expected.

[omahane]

@davidmpickett The changes to the design would change the header and content help text for all Accordions. I want to confirm that this is expected.

In fact, there are a number of changes in the design that would affect the paragraphs wherever they appear. Is that desired?

[davidmpickett]

@davidmpickett The changes to the design would change the header and content help text for all Accordions. I want to confirm that this is expected.

In fact, there are a number of changes in the design that would affect the paragraphs wherever they appear. Is that desired?

Yes. We iterated on the help text with that specifically in mind. It is possible that there may have been an instance or two that slipped through unintentionally. Once this is in PR, I can do a final review to confirm that we don’t have any unintended consequences

[omahane]

Spotlight call to action link help text

@davidmpickett

docroot/modules/contrib/linkit/src/Plugin/Field/FieldWidget/LinkitWidget.php
needs to change to allow for the use of field help text, which would be the ideal solution, but an issue needs to be made on the module to allow that.

[davidmpickett]

@xiongjaneg @aklausmeier Here's a small spinoff ticket that would likely need to go to the CMS Platform team for resolution. Not likely a high-priority item, but wanted to make sure it was documented #17170

[laflannery]

Noting that I changed the above ticket completely. It is a request to add a CSS property to the CMS design system as this should be a global change

[omahane]

I created that ticket for the module: https://www.drupal.org/project/linkit/issues/3420280

[davidmpickett]

Spotlight call to action link help text

@davidmpickett

docroot/modules/contrib/linkit/src/Plugin/Field/FieldWidget/LinkitWidget.php needs to change to allow for the use of field help text, which would be the ideal solution, but an issue needs to be made on the module to allow that.

@omahane here's a stub of an issue for bringing this to CMS Platform team #17201

@xiongjaneg Again, not likely a high priority, but just documenting for consideration