Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff templates: adopt V1 components where components are not used #17066

Closed
4 tasks
laflannery opened this issue Jan 29, 2024 · 4 comments
Closed
4 tasks

Staff templates: adopt V1 components where components are not used #17066

laflannery opened this issue Jan 29, 2024 · 4 comments
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area va-icon

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 29, 2024

Description

To be in compliance with the Design System and to help make sure our products receive design and accessibility updates, Staff templates needs to be updated to use the most recent versions of all available components.

Example pages:

Elements that are not using components that should be

Leadership List template & Staff Detail template

  1. Link
    • This is for the download links and email links on the Staff Detail templates (example) and the Name links on the listing template
    • These are currently not using a component at all but they should be using the v1 component
  2. Telephone
    • These are currently not using a component at all but they should be using the v1 component
    • Exts in phone numbers within the component are parsed correctly

Acceptance Criteria

  • Link component has been added
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review
@laflannery laflannery added Needs refining Issue status VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) accessibility Issues related to accessibility labels Jan 29, 2024
@laflannery laflannery changed the title Update Staff tempaltes with components Update Staff templates with components Jan 29, 2024
@maxx1128
Copy link

I estimate this at a 2 for the same reasons as News Releases.

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@jilladams jilladams changed the title Update Staff templates with components Update Staff templates with components (v1) Mar 27, 2024
@jilladams jilladams changed the title Update Staff templates with components (v1) Staff templates: adopt V1 and V3 components where components are not used Mar 27, 2024
@jilladams jilladams changed the title Staff templates: adopt V1 and V3 components where components are not used Staff templates: adopt V1 components where components are not used Mar 27, 2024
@laflannery
Copy link
Contributor Author

Telephone moved to #16148

@eselkin
Copy link
Contributor

eselkin commented Apr 24, 2024

Estimate a 2 as well. The links on the Leadership page is simple. The links on detail pages is slightly more complex, but should be done in conjunction with icon update.

Do we also update the email link to va-link component? This is pretty simple, except the <a> tag currently has a target="blank" on it, but no rel attribute. Not sure if we want to keep the target. If we do then we should keep as a <a> tag.

@randimays
Copy link
Contributor

Successfully validated in production. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area va-icon
Projects
None yet
Development

No branches or pull requests

7 participants