Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Components] Upgrade V1 components to V3 for the Benefits Hub Landing Page #16981

Closed
5 tasks done
FranECross opened this issue Jan 23, 2024 · 2 comments
Closed
5 tasks done
Assignees
Labels
Public Websites Scrum team in the Sitewide crew sitewide V3 Components Update to V3 VA.gov frontend CMS team practice area

Comments

@FranECross
Copy link

FranECross commented Jan 23, 2024

Background

The Design team is migrating all V1 components to V3 on February 16, 2024, which means that the PW team needs to upgrade any of our products using V1 to V3.

Example pages:

List of Components

V1 components that need to be upgraded (Actionable)

  1. Accordion
    • Accordion sections, in the right side bar, need to be updated to v3.
  2. Alert
    • In the main body content under "On the page", needs to be updated to v3.

Documentation

Sitewide V3 DS component review spreadsheet

User story

AS A PO/PM for the PW team products, as well as for the Design team
I WANT all V1 components to be upgraded to V3 either before or soon after February 16, 2024
SO THAT all PW products are in alignment with the new components.

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • V3 components are now used for the accordion and Back to top
  • V3 component features display correctly
  • verify/review the E2E tests
  • check desktop and mobile
  • a11y review
@FranECross FranECross added Needs refining Issue status Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area and removed Needs refining Issue status labels Jan 23, 2024
@FranECross FranECross added the V3 Components Update to V3 label Feb 7, 2024
@randimays randimays self-assigned this Feb 16, 2024
@randimays
Copy link
Contributor

Successfully validated in staging. Will check again in prod this afternoon.

@randimays
Copy link
Contributor

Successfully validated in production. Closing!

Alert (Mobile)
Screenshot 2024-02-21 at 5 04 42 PM

Alert (Desktop)
Screenshot 2024-02-21 at 5 04 52 PM

Accordion (Desktop - open)
Screenshot 2024-02-21 at 5 04 56 PM

Accordion (Desktop - closed)
Screenshot 2024-02-21 at 5 05 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew sitewide V3 Components Update to V3 VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants