Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16981 v3 upgrade for Benefit Hub Landing Page #1917

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Feb 16, 2024

Summary

Upgrade the va-accordion and va-alert component for the Benefit Hub landing pages.

Related issue(s)

Testing done

Tested locally at /health-care and careers-employment.

Screenshots

Screenshot 2024-02-16 at 2 31 42 PM Screenshot 2024-02-16 at 2 31 48 PM Screenshot 2024-02-16 at 2 31 55 PM

Acceptance criteria

  • V3 components are now used for the accordion and alert
  • V3 component features display correctly
  • check desktop and mobile
  • a11y review

@randimays randimays requested review from a team as code owners February 16, 2024 20:25
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16981-v3-upgrade February 16, 2024 20:50 Inactive
Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants