Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VAMC Facility template to adopt V3 accordion component #16963

Closed
2 of 10 tasks
laflannery opened this issue Jan 22, 2024 · 8 comments
Closed
2 of 10 tasks

Update VAMC Facility template to adopt V3 accordion component #16963

laflannery opened this issue Jan 22, 2024 · 8 comments
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 22, 2024

Description

VAMC Facility pages need the following updates to components:

Example pages:

List of Components

V1 components that need to be upgraded (Actionable)

  1. Accordion
    • Accordion sections (Prepare for your visit and services) are using the v1 component and need to be updated to v3.

Not in scope

Acceptance Criteria

  • Accordion component has been updated to v3
  • Update and run existing test(s).
  • Presentation is verified the same across all supported browsers on Mac & Win
    • Chrome
    • Firefox
    • Safari
    • Edge
    • Android
    • iOS
  • Requires accessibility review
@laflannery laflannery added VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status accessibility Issues related to accessibility labels Jan 22, 2024
@maxx1128
Copy link

I estimate this ticket at a 3 for moving over a good amount of relatively simple elements over to components.

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@jilladams jilladams changed the title Update VAMC Facility template with components Update VAMC Facility template with components (v3, v1) Mar 27, 2024
@jilladams
Copy link
Contributor

TO DO: @jilladams split out V1 work to new ticket

@jilladams jilladams changed the title Update VAMC Facility template with components (v3, v1) Update VAMC Facility template to adopt V3 accordion component Mar 27, 2024
@eselkin eselkin assigned eselkin and unassigned maxx1128 Apr 5, 2024
@eselkin
Copy link
Contributor

eselkin commented Apr 6, 2024

Should this also change: https://va.gov/boston-health-care/health-services/?

Nevermind, I see there's another ticket for that.

@jilladams
Copy link
Contributor

Due to #17807 popping up, where adoption of components ran into some browser-specific styling issues, I've added ACs here to cover cross-browser verification.

@laflannery
Copy link
Contributor Author

laflannery commented Apr 11, 2024

Screenshots from Eli's PR for ACs:

FF Windows
image

Edge (I didn't put the fancy bookmarklet on Edge but confirmed these are the v3 variant)
image

Chrome Windows
image

FF Mac
Screenshot 2024-04-11 at 8 21 29 AM

Chrome Mac
Screenshot 2024-04-11 at 8 12 17 AM

Safari (no bookmarklet)
Screenshot 2024-04-11 at 8 14 19 AM

Mobile
image

@jilladams
Copy link
Contributor

Thoughts: #16997 (comment)
tl;dr: let's use mobile emulator to test lower envs on desktop, and verify on phones in prod.

@laflannery
Copy link
Contributor Author

Update above comment to include mobile emulator screenshot

@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@laflannery
Copy link
Contributor Author

Confirmed on Prod:
Screenshot 2024-04-15 at 8 39 10 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

6 participants