-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front end: Add Prepare for your visit to VBA Facility page #16921
Comments
@xiongjaneg I noticed that the prototype had no annotations (for headings and such) so I added some but was told by Jordan that the Figma linked above is an older file that only shows the prototype we used for testing. The most up to date VBA file is actually the Sketch file, and this actually has the annotations I remembered. Can we/should we have this as the source of truth in the ticket description? |
@laflannery Yes please. That may have been my error (I get my Figmas and Sketches mixed up some times). |
@maxx1128 @thejordanwood did these accordions get a design review after implementation? |
@laflannery have you had a chance to review also? |
@mmiddaugh Sorry, it's entirely my fault for skipping the design and accessibility review. I completely spaced on that. I'll get a tugboat instance of this setup. Update: |
Edit: I was looking at the VAMC page, please ignore this feedback. @maxx1128 I have a couple of notes:
|
I added test content in staging |
@thejordanwood Both of these issues are on the CMS side of things. I checked my local tugboat version of the CMS with the same data, and the Transportation headings are being set to H3s there and the Chaplain services accordion has a button set there too. |
@maxx1128 The page you had added in the original comment above is a live VAMC page, see Slack thread for question and discussion about this. So the issues mentioned do not apply to the VBA pages. For the VBA pages and the scope of this ticket, @mmiddaugh added a test page she had been looking at in staging and I just reviewed - everything looks good! |
@maxx1128 As Laura mentioned, please ignore my previous feedback for the VAMC page. The VBA page that @mmiddaugh added here looks good to me. This is approved on my end! |
Based on approvals in comments, closing. |
User Story or Problem Statement
Resources
Acceptance Criteria
The text was updated successfully, but these errors were encountered: