Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end: Add Prepare for your visit to VBA Facility page #16921

Closed
4 tasks done
xiongjaneg opened this issue Jan 19, 2024 · 11 comments
Closed
4 tasks done

Front end: Add Prepare for your visit to VBA Facility page #16921

xiongjaneg opened this issue Jan 19, 2024 · 11 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area

Comments

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Jan 19, 2024

User Story or Problem Statement

  • As a Veteran, I need to know how to find and what to bring to a VBA Regional Office prior to my visit.
  • As a VBA Regional Office editor, I need to help Veterans understand how to find my regional office and what to bring at their visit.

Resources

Acceptance Criteria

  • Content added by an editor to a Prepare for your visit accordion shows on the VA.gov page.
  • Accordion component uses USWDS V3 component.
  • Requires design review
  • Requires accessibility review
@xiongjaneg xiongjaneg added Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status VA.gov frontend CMS team practice area Regional office CMS managed VBA product owned by the Facilities team labels Jan 19, 2024
@laflannery
Copy link
Contributor

@xiongjaneg I noticed that the prototype had no annotations (for headings and such) so I added some but was told by Jordan that the Figma linked above is an older file that only shows the prototype we used for testing. The most up to date VBA file is actually the Sketch file, and this actually has the annotations I remembered. Can we/should we have this as the source of truth in the ticket description?

@xiongjaneg
Copy link
Contributor Author

@laflannery Yes please. That may have been my error (I get my Figmas and Sketches mixed up some times).

@mmiddaugh
Copy link
Contributor

@maxx1128 @thejordanwood did these accordions get a design review after implementation?

@mmiddaugh mmiddaugh reopened this Feb 15, 2024
@mmiddaugh
Copy link
Contributor

@laflannery have you had a chance to review also?

@maxx1128
Copy link

maxx1128 commented Feb 15, 2024

@mmiddaugh Sorry, it's entirely my fault for skipping the design and accessibility review. I completely spaced on that. I'll get a tugboat instance of this setup.

Update: my tugboat is rebuilding now based on main, so the changes should be visible at here once it rebuilds - https://web-txcrk8bym4a0ivw3xfr8xvdhezmls36f.demo.cms.va.gov/cleveland-va-regional-benefit-office/locations/cleveland-va-regional-benefit-office/#prepare-for-your-visit The "Prepare for your Visit" section can be seen live here: https://www.va.gov/cheyenne-health-care/locations/cheyenne-va-medical-center/#prepare-for-your-visit

@thejordanwood
Copy link

thejordanwood commented Feb 16, 2024

Edit: I was looking at the VAMC page, please ignore this feedback.

@maxx1128 I have a couple of notes:

  • I'm unsure how heading levels are being controlled here. The headings in the Transportation for Veterans to their Appointments accordion should be H4. The heading levels look fine in the other accordions.
  • In the Chaplain services and chapels accordion, the button should be replaced with an active link.

@mmiddaugh
Copy link
Contributor

I added test content in staging
Try this preview page in staging

@maxx1128
Copy link

@thejordanwood Both of these issues are on the CMS side of things. I checked my local tugboat version of the CMS with the same data, and the Transportation headings are being set to H3s there and the Chaplain services accordion has a button set there too.

@laflannery
Copy link
Contributor

@maxx1128 The page you had added in the original comment above is a live VAMC page, see Slack thread for question and discussion about this. So the issues mentioned do not apply to the VBA pages.

For the VBA pages and the scope of this ticket, @mmiddaugh added a test page she had been looking at in staging and I just reviewed - everything looks good!
Screenshot 2024-02-19 at 8 40 37 AM

@thejordanwood
Copy link

@maxx1128 As Laura mentioned, please ignore my previous feedback for the VAMC page. The VBA page that @mmiddaugh added here looks good to me. This is approved on my end!

@jilladams
Copy link
Contributor

Based on approvals in comments, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

6 participants